You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Antonio Fornie <an...@gmail.com> on 2014/04/09 15:52:02 UTC

Review Request 20154: Fix: ParamGenericValidationWorker shouldn't be case sensitive

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20154/
-----------------------------------------------------------

Review request for cloudstack, Alena Prokharchyk and Hugo Trippaers.


Repository: cloudstack-git


Description
-------

Fix: ParamGenericValidationWorker shouldn't be case sensitive


Diffs
-----

  server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java 7a73b8a 
  server/test/com/cloud/api/dispatch/ParamGenericValidationWorkerTest.java 8f9709c 

Diff: https://reviews.apache.org/r/20154/diff/


Testing
-------

Maven build, normal execution of the case and Unit Test


Thanks,

Antonio Fornie


Re: Review Request 20154: Fix: ParamGenericValidationWorker shouldn't be case sensitive

Posted by Alena Prokharchyk <al...@citrix.com>.

> On April 14, 2014, 5:18 p.m., Alena Prokharchyk wrote:
> > Ship It!

Fix is committed to 4.4 and master branches.


- Alena


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20154/#review40274
-----------------------------------------------------------


On April 9, 2014, 1:52 p.m., Antonio Fornie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20154/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 1:52 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix: ParamGenericValidationWorker shouldn't be case sensitive
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java 7a73b8a 
>   server/test/com/cloud/api/dispatch/ParamGenericValidationWorkerTest.java 8f9709c 
> 
> Diff: https://reviews.apache.org/r/20154/diff/
> 
> 
> Testing
> -------
> 
> Maven build, normal execution of the case and Unit Test
> 
> 
> Thanks,
> 
> Antonio Fornie
> 
>


Re: Review Request 20154: Fix: ParamGenericValidationWorker shouldn't be case sensitive

Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20154/#review40274
-----------------------------------------------------------

Ship it!


Ship It!

- Alena Prokharchyk


On April 9, 2014, 1:52 p.m., Antonio Fornie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20154/
> -----------------------------------------------------------
> 
> (Updated April 9, 2014, 1:52 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fix: ParamGenericValidationWorker shouldn't be case sensitive
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/dispatch/ParamGenericValidationWorker.java 7a73b8a 
>   server/test/com/cloud/api/dispatch/ParamGenericValidationWorkerTest.java 8f9709c 
> 
> Diff: https://reviews.apache.org/r/20154/diff/
> 
> 
> Testing
> -------
> 
> Maven build, normal execution of the case and Unit Test
> 
> 
> Thanks,
> 
> Antonio Fornie
> 
>