You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/01 15:46:44 UTC

[GitHub] [incubator-nuttx] v01d opened a new pull request #1928: nrf52_ppi: fix group disable and add group clear operation

v01d opened a new pull request #1928:
URL: https://github.com/apache/incubator-nuttx/pull/1928


   ## Summary
   
   This change fixes wrong implementation of PPI channel group disable operation. Also, this adds the possibility of clearing all channels from a group in one operation (useful for ensuring a clean slate). Finally, this adds various DEBUGASSERTS() that ensure that when enabling a channel, it wasn't already enabled and viceversa. This helps detecting when using a PPI channel already in use.
   
   ## Impact
   
   Bug fix, extra operation and extra checks for nRF52's PPI peripheral.
   
   ## Testing
   
   Normal use of PPI


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #1928: nrf52_ppi: fix group disable and add group clear operation

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1928:
URL: https://github.com/apache/incubator-nuttx/pull/1928#issuecomment-702465613


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #1928: nrf52_ppi: fix group disable and add group clear operation

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1928:
URL: https://github.com/apache/incubator-nuttx/pull/1928


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org