You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/25 00:49:35 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request #10448: fix oracle jdbc load me error
strongduanmu opened a new pull request #10448:
URL: https://github.com/apache/shardingsphere/pull/10448
Changes proposed in this pull request:
- fix oracle load table meta data error
- fix oracle load non-materialized view index error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #10448: fix oracle meta data load error
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #10448:
URL: https://github.com/apache/shardingsphere/pull/10448#discussion_r638427471
##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/IndexMetaDataLoader.java
##########
@@ -54,6 +56,10 @@
result.add(new IndexMetaData(indexName));
}
}
+ } catch (SQLException ex) {
Review comment:
> final
@tristaZero fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #10448: fix oracle meta data load error
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #10448:
URL: https://github.com/apache/shardingsphere/pull/10448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #10448: fix oracle meta data load error
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #10448:
URL: https://github.com/apache/shardingsphere/pull/10448#discussion_r638425739
##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/builder/loader/IndexMetaDataLoader.java
##########
@@ -54,6 +56,10 @@
result.add(new IndexMetaData(indexName));
}
}
+ } catch (SQLException ex) {
Review comment:
final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org