[GitHub] sardell edited a comment on issue #1323: METRON-1971: Short timeout value in Cypress may cause build failures

[GitBox <gi...@apache.org>]

sardell edited a comment on issue #1323: METRON-1971: Short timeout value in Cypress may cause build failures
URL: https://github.com/apache/metron/pull/1323#issuecomment-458109204
 
 
   @ottobackwards I agree, anything based on a time will eventually be unreliable at some point. In this case, I am overriding a value that acts as a safety because Cypress will re-run assertions over and over until they are true or reach the timeout value specified. Indeed, it would be better if there was a way for Cypress to determine when to exit an assertion that wasn't time-based, but I'm guessing they chose to do things this way because of the nature of e2e testing in a browser. For example, in the case where the UI builds fine but contains an error that prevents part of the page from rendering, Cypress will re-run an assertion on a non-existing element over and over. Without a timeout value, it will do so infinitely. Protractor has similar timeout configurations: https://github.com/angular/protractor/blob/master/docs/timeouts.md

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services