You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/09/01 17:04:00 UTC
[jira] [Work logged] (BEAM-7980) External environment with
containerized worker pool
[ https://issues.apache.org/jira/browse/BEAM-7980?focusedWorklogId=304988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304988 ]
ASF GitHub Bot logged work on BEAM-7980:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/19 17:03
Start Date: 01/Sep/19 17:03
Worklog Time Spent: 10m
Work Description: tweise commented on pull request #9398: [BEAM-7980] Exactly once artifact retrieval for Python SDK worker pool
URL: https://github.com/apache/beam/pull/9398#discussion_r319767728
##########
File path: sdks/python/container/boot.go
##########
@@ -105,18 +107,57 @@ func main() {
// (2) Retrieve and install the staged packages.
- dir := filepath.Join(*semiPersistDir, "staged")
+ func() {
- files, err := artifact.Materialize(ctx, *artifactEndpoint, info.GetRetrievalToken(), dir)
- if err != nil {
- log.Fatalf("Failed to retrieve staged files: %v", err)
- }
+ installCompleteFile := filepath.Join(os.TempDir(), "beam.install.complete")
Review comment:
Done! Can this be accomplished through the gradle plugin also (w/o extra go install)? Would be nice to have this integrated like Spotless for Java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 304988)
Time Spent: 8h (was: 7h 50m)
> External environment with containerized worker pool
> ---------------------------------------------------
>
> Key: BEAM-7980
> URL: https://issues.apache.org/jira/browse/BEAM-7980
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-harness
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Time Spent: 8h
> Remaining Estimate: 0h
>
> Augment Beam Python docker image and boot.go so that it can be used to launch BeamFnExternalWorkerPoolServicer.
> [https://docs.google.com/document/d/1z3LNrRtr8kkiFHonZ5JJM_L4NWNBBNcqRc_yAf6G0VI/edit#heading=h.lnhm75dhvhi0]
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)