You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/09/08 12:35:53 UTC

[GitHub] [skywalking-banyandb] hanahmily commented on pull request #165: Add stream schema cli

hanahmily commented on PR #165:
URL: https://github.com/apache/skywalking-banyandb/pull/165#issuecomment-1240658648

   Most cases failed to expect the first one. This might relate to the following place:
   
   https://github.com/apache/skywalking-banyandb/blob/main/banyand/liaison/http/server.go#L125
   
   The HTTP server blocks and the `GracefulStop` doesn't contain any operation to stop the server. Would you please use `http.Server` instead of `http.ListenAndServer` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org