[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #1013: MINIFICPP-1487 Always yield if no input flow files were processed

[GitBox <gi...@apache.org>]

hunyadi-dev commented on a change in pull request #1013:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1013#discussion_r580349065



##########
File path: libminifi/src/core/Processor.cpp
##########
@@ -277,6 +286,28 @@ void Processor::onTrigger(const std::shared_ptr<ProcessContext> &context, const
   }
 }
 
+void Processor::callOnTrigger(const std::shared_ptr<ProcessContext>& context, const std::shared_ptr<ProcessSession>& session) {
+  uint64_t num_incoming_flow_files_queued_before = numIncomingFlowFilesQueued();
+  onTrigger(context, session);  // virtual method overridden by subclasses

Review comment:
       The lock is unlocked inbetween the calls. Could there be no issue with subsequent calls to this function on multiple threads? Eg. can this case not happen?
   1. Count flowfiles before
   1. Call onTrigger
   1. Add files to incoming connections on a different thread
   1. Count flowfiles after




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org