You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/13 06:55:22 UTC
[GitHub] [yunikorn-site] KatLantyss opened a new pull request, #230: [YUNIKORN-1412] fix render issue in Scheduler cache removal design doc.
KatLantyss opened a new pull request, #230:
URL: https://github.com/apache/yunikorn-site/pull/230
Fix render issue in Scheduler cache removal design doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] craigcondit commented on a diff in pull request #230: [YUNIKORN-1412] fix render issue in Scheduler cache removal design doc.
Posted by GitBox <gi...@apache.org>.
craigcondit commented on code in PR #230:
URL: https://github.com/apache/yunikorn-site/pull/230#discussion_r1047390950
##########
package.json:
##########
@@ -12,7 +12,7 @@
"dependencies": {
"@docusaurus/core": "2.1.0",
"@docusaurus/preset-classic": "2.1.0",
- "@docusaurus/theme-search-algolia": "2.1.0",
+ "@docusaurus/theme-search-algolia": "^2.2.0",
Review Comment:
Please remove this from the PR.
##########
docs/design/cache_removal.md:
##########
@@ -32,10 +32,14 @@ It describes the changes planned based on the analysis that was done of the curr
## Goals
The goal is to provide the same functionality before and after the change.
-- unit tests before and after the merge must all pass.
-- Smoke tests defined in the core should all pass without major changes <sup id="s1">[definition](#f1)</sup>.
+- Unit tests before and after the merge must all pass.
+- Smoke tests defined in the core should all pass without major change.
Review Comment:
'change' should be 'changes' here.
##########
docs/design/cache_removal.md:
##########
@@ -47,10 +51,11 @@ This short period can have an impact on the scheduling decisions.
One of which is logged as [YUNIKORN-169](https://issues.apache.org/jira/browse/YUNIKORN-169).
A further point is the complexity that the two structure brings to the code.
-A distinct set of messages to communicate between the scheduler and the cache.
-A one on one mapping between the scheduler and cache objects shows that the distinction is probably more artificial than required.
+A distinct set of messages to communicate between the scheduler and the cache. A one on one mapping between the scheduler and cache objects shows that the distinction is probably more artificial than required.
Review Comment:
one on one should be hyphenated: one-on-one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s closed pull request #230: [YUNIKORN-1412] fix render issue in Scheduler cache removal design doc.
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #230: [YUNIKORN-1412] fix render issue in Scheduler cache removal design doc.
URL: https://github.com/apache/yunikorn-site/pull/230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org