You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (Created) (JIRA)" <ji...@apache.org> on 2012/02/02 19:50:54 UTC
[jira] [Created] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize and getDefaultReplication
ViewFileSystem does not correctly implement getDefaultBlockSize and getDefaultReplication
-----------------------------------------------------------------------------------------
Key: HADOOP-8014
URL: https://issues.apache.org/jira/browse/HADOOP-8014
Project: Hadoop Common
Issue Type: Bug
Components: fs
Affects Versions: 0.23.0, 0.24.0
Reporter: Daryn Sharp
Assignee: Daryn Sharp
{{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248483#comment-13248483 ]
John George commented on HADOOP-8014:
-------------------------------------
bq. In the new patch - {{Its spec and implementation is identical to {@link ViewFs}.}} not sure what you mean here. Can you please add description on when this is used or what error it conveys? Once you address that I am +1 for the patch, if the test failure is unrelated to this.
Added a better description.
TestViewFsTrash seemed to fail in earlier builds as well (eg: [829|https://builds.apache.org/job/PreCommit-HADOOP-Build/829//testReport/], [830|https://builds.apache.org/job/PreCommit-HADOOP-Build/830//testReport/]).
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249246#comment-13249246 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1007 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1007/])
HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)
HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555)
HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247385#comment-13247385 ]
Suresh Srinivas commented on HADOOP-8014:
-----------------------------------------
BTW if you take care of these comments, I am +1 for the patch.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Status: Open (was: Patch Available)
Canceling patch to address Suresh's comment.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248572#comment-13248572 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-8014:
------------------------------------------------
Forgot to add the new file NotInMountpointException.java?
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249037#comment-13249037 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2024 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2024/])
HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Status: Patch Available (was: Open)
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247548#comment-13247548 ]
Daryn Sharp commented on HADOOP-8014:
-------------------------------------
Are you suggesting that {{fs.getDefaultReplication(Path)}} should automatically delegate to the filesystem of the path? Would it be better to call {{checkPath(Path)}}?
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242730#comment-13242730 ]
Hadoop QA commented on HADOOP-8014:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520663/HADOOP-8014.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 7 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/806//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/806//console
This message is automatically generated.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Attachment: HADOOP-8014.patch
Attaching a patch with minor cosmetic changes (line alignment etc, @keyword etc)
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Attachment: HADOOP-8014.patch
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Status: Open (was: Patch Available)
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247564#comment-13247564 ]
John George commented on HADOOP-8014:
-------------------------------------
bq. # FileSystem#getServerDefaults() - is it better to day path p is used for identifying a destination file system? Same for FileSystem#getDefaultReplication(path). Perhaps adding information like a FileSystem could have another file system or file systems it could be delegating the call to. Path helps identifying the underlying file system?
I understand that you expect a comment change here - basically add a comment explaining why {{path}} is used?
bq. # Please move NotInMountException to a separate java file
done
bq. # FileSystemTestHelper#createParent not used in createFile() method. Do you need multiple overloaded variants of that method?
removed.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize and getDefaultReplication
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Attachment: HADOOP-8014.patch
> ViewFileSystem does not correctly implement getDefaultBlockSize and getDefaultReplication
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248466#comment-13248466 ]
Hadoop QA commented on HADOOP-8014:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521558/HADOOP-8014.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.fs.viewfs.TestViewFsTrash
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/831//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/831//console
This message is automatically generated.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241246#comment-13241246 ]
John George commented on HADOOP-8014:
-------------------------------------
I will attach a patch with the unit test fixes and addressing comment from Daryn. The following is the basic theme that this patch follows. Suggestions and comments welcome:
- {{getDefaultBlockSize}}, {{getDefaultReplication}} and {{getServerDefaults}} APIs with no {{path}} argument is invalid as far as viewFS is concerned. The logic behind this is that viewFS has no 'default' mount point. Even in cases where {{ROOT_PATH}} is mounted, my thinking is that it is not the 'default' mountpoint. Hence, viewFS will throw an exception in such cases.
- Any call with {{path}} argument given, will be resolved accordingly and the corresponding FS routing will be called.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248473#comment-13248473 ]
Suresh Srinivas commented on HADOOP-8014:
-----------------------------------------
bq. Are you suggesting that fs.getDefaultReplication(Path) should automatically delegate to the filesystem of the path? Would it be better to call checkPath(Path)?
bq. I understand that you expect a comment change here - basically add a comment explaining why path is used?
File system defaults with a path seems to be confusing - given common understanding would be defaults are the file system level. These variants of methods become more meaningful, once a user of API understands that a FileSystem implementation could be front ending another file system or file systems. The path is used only for identifying an underlying file system, where necessary. I was thinking if we could capture that information, to avoid confusion, where user might end up thinking that the defaults are associated with a file corresponding to the path.
Makes sense?
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-8014:
--------------------------------
Attachment: (was: HADOOOP-8014.branch-1.patch)
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242418#comment-13242418 ]
Daryn Sharp commented on HADOOP-8014:
-------------------------------------
Looking good, however {{FileFileSystem}}'s no-path variants of the methods need to call the path variant with the root path instead of calling through to the underlying fs no-path method. Otherwise there are problems such as {{ChrootFileSystem}} not getting a chance to rewrite the path.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248706#comment-13248706 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2034 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2034/])
HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555)
Result = ABORTED
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248588#comment-13248588 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2032 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2032/])
HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507)
Result = ABORTED
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248477#comment-13248477 ]
Suresh Srinivas commented on HADOOP-8014:
-----------------------------------------
Just realized - my previous comment is addressed by your new patch.
In the new patch - {{Its spec and implementation is identical to {@link ViewFs}.}} not sure what you mean here. Can you please add description on when this is used or what error it conveys? Once you address that I am +1 for the patch, if the test failure is unrelated to this.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Affects Version/s: 0.23.2
Assignee: John George (was: Daryn Sharp)
Summary: ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (was: ViewFileSystem does not correctly implement getDefaultBlockSize and getDefaultReplication)
Thanks to Daryn for handing over the change he made in getDefaultBlockSize and getDefaultReplication. I am attaching a patch with getDefaultBlockSize, getDefaultReplication, and getContentSummary. The tests are added as part of HDFS-3121.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248550#comment-13248550 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2094 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2094/])
HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248638#comment-13248638 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2023 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2023/])
HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246408#comment-13246408 ]
Daryn Sharp commented on HADOOP-8014:
-------------------------------------
+1 I'd rather see the logic pushed back down as in an earlier patch, but I think it's good enough for now.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249239#comment-13249239 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #220 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/220/])
HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310557)
svn merge -c 1310507 from trunk. FIXES: HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310513)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310557
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310513
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248632#comment-13248632 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2098 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2098/])
HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555)
Result = SUCCESS
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Status: Patch Available (was: Open)
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242714#comment-13242714 ]
John George commented on HADOOP-8014:
-------------------------------------
bq. Also, do the existing tests already verify that the correct replication factor and block size are returned, and that a non-default replication and block size are honored?
These are tested as part of HDFS-3121.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246321#comment-13246321 ]
John George commented on HADOOP-8014:
-------------------------------------
Daryn,
Do you have any other concerns about the patch?
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239855#comment-13239855 ]
Daryn Sharp commented on HADOOP-8014:
-------------------------------------
Just noticed that both of the getDefaultBlockSize methods in viewfs are throwing an exception as getDefaultReplication.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242419#comment-13242419 ]
Daryn Sharp commented on HADOOP-8014:
-------------------------------------
Also, do the existing tests already verify that the correct replication factor and block size are returned, and that a non-default replication and block size are honored?
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Status: Patch Available (was: Open)
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Attachment: HADOOP-8014.patch
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Status: Patch Available (was: Open)
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249268#comment-13249268 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1042 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1042/])
HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)
HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (Revision 1310555)
HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310555
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/NotInMountpointException.java
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Attachment: HADOOP-8014.patch
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249064#comment-13249064 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2035 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2035/])
HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)
Result = ABORTED
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247384#comment-13247384 ]
Suresh Srinivas commented on HADOOP-8014:
-----------------------------------------
bq. is it better to day
is it better to say. I had to think for a long time to figure out what I was trying to say :-)
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244252#comment-13244252 ]
Daryn Sharp commented on HADOOP-8014:
-------------------------------------
{{FilterFileSystem}}'s no-path methods should be calling the path variant. (Sorry I butchered it as {{FileFileSystem}} in an earlier comment). Pushing this behavior up into {{ChrootFileSystem}} will force any other subclass of {{FilterFileSystem}} that wants to alter the behavior of path handling to implement both methods. I think putting the behavior in {{FilterFileSystem}} is more future-proof for arbitrarily stackable filesystems.
Otherwise, looks great.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239890#comment-13239890 ]
Hadoop QA commented on HADOOP-8014:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520183/HADOOP-8014.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.fs.TestFilterFileSystem
org.apache.hadoop.ha.TestZKFailoverController
org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
org.apache.hadoop.ha.TestFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/792//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/792//console
This message is automatically generated.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244329#comment-13244329 ]
Daryn Sharp commented on HADOOP-8014:
-------------------------------------
I seem to recall that Hive's {{ProxyFileSystem}} is a subclass of {{FilterFileSystem}} that does path rewriting. You may want to check that it won't break if {{FilterFileSystem}} doesn't loop the no-path methods to the path variants.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247294#comment-13247294 ]
Hadoop QA commented on HADOOP-8014:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521506/HADOOP-8014.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/825//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/825//console
This message is automatically generated.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244266#comment-13244266 ]
John George commented on HADOOP-8014:
-------------------------------------
Thanks for looking at the patch again Daryn - always appreciate your input. About moving the behavior to {{FilterFileSystem}}, I was thinking the other way round - I feel it is better to keep the behavior in {{ChrootFileSystem}} since, as of now, it is the characteristic of {{ChrootFileSystem}} to have a {{path}}. Anyone inheriting {{FilterFileSystem}} should probably implement the same behavior like you said.
Other than this being a debatable change (since it could be either way), do you actually see a defect or an issue in this change?
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Status: Open (was: Patch Available)
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248549#comment-13248549 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2019 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2019/])
HADOOP-8014. ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary (John George via bobby) (Revision 1310507)
Result = FAILURE
bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310507
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FilterFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemTestHelper.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Attachment: HADOOP-8014.patch
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Daryn Sharp (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-8014:
--------------------------------
Attachment: HADOOOP-8014.branch-1.patch
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248497#comment-13248497 ]
Hadoop QA commented on HADOOP-8014:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521694/HADOOP-8014.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified test files.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/832//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/832//console
This message is automatically generated.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249030#comment-13249030 ]
Hudson commented on HADOOP-8014:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2099 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2099/])
HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. Missed adding the file in the earlier commit. (Revision 1310631)
HDFS-3121. Add HDFS tests for HADOOP-8014 change. Contributed by John George. (Revision 1310630)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310631
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/viewfs/TestViewFsDefaultValue.java
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1310630
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Status: Patch Available (was: Open)
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239867#comment-13239867 ]
Hadoop QA commented on HADOOP-8014:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520179/HADOOP-8014.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.fs.TestFilterFileSystem
org.apache.hadoop.ha.TestZKFailoverController
org.apache.hadoop.fs.viewfs.TestViewFileSystemWithAuthorityLocalFileSystem
org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
org.apache.hadoop.fs.viewfs.TestViewFsTrash
org.apache.hadoop.fs.viewfs.TestViewFileSystemLocalFileSystem
org.apache.hadoop.ha.TestFailoverController
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/791//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/791//console
This message is automatically generated.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Daryn Sharp (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239869#comment-13239869 ]
Daryn Sharp commented on HADOOP-8014:
-------------------------------------
Please double check that internalGetServerDefaults is still necessary. I think it's a remnant of an earlier attempt.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Attachment: HADOOP-8014.patch
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247383#comment-13247383 ]
Suresh Srinivas commented on HADOOP-8014:
-----------------------------------------
Nice work.
Most of these are minor comments.
# FileSystem#getServerDefaults() - is it better to day path p is used for identifying a destination file system? Same for FileSystem#getDefaultReplication(path). Perhaps adding information like a FileSystem could have another file system or file systems it could be delegating the call to. Path helps identifying the underlying file system?
# Please move NotInMountException to a separate java file
# FileSystemTestHelper#createParent not used in createFile() method. Do you need multiple overloaded variants of that method?
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "Robert Joseph Evans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-8014:
----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
0.23.3
Status: Resolved (was: Patch Available)
Thanks John, With Surresh's +1 and my own I have merged this into branch-0.23, branch-2, and trunk
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Fix For: 0.23.3, 2.0.0
>
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244415#comment-13244415 ]
John George commented on HADOOP-8014:
-------------------------------------
I suppose if Hive's {{ProxyFileSystem}} is using it as of now, they would be overriding the method any way because otherwise would it end up using {{FileSystem}} methods, which is what these methods do in the patch as well. So, it shouldn't be an issue.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239866#comment-13239866 ]
John George commented on HADOOP-8014:
-------------------------------------
Thanks for catching that Daryn. Attached a new patch.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8014) ViewFileSystem does not correctly
implement getDefaultBlockSize, getDefaultReplication, getContentSummary
Posted by "John George (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John George updated HADOOP-8014:
--------------------------------
Status: Open (was: Patch Available)
Thanks for catching that Daryn. I will upload a patch with the fix soon.
> ViewFileSystem does not correctly implement getDefaultBlockSize, getDefaultReplication, getContentSummary
> ---------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-8014
> URL: https://issues.apache.org/jira/browse/HADOOP-8014
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.0, 0.23.2, 0.24.0
> Reporter: Daryn Sharp
> Assignee: John George
> Attachments: HADOOP-8014.patch, HADOOP-8014.patch, HADOOP-8014.patch
>
>
> {{ViewFileSystem}} incorrectly returns the {{FileSystem}} default values for {{getDefaultBlockSize()}} and {{getDefaultReplication()}}. This causes files to be created with incorrect values. The problem is that the current apis are insufficient for viewfs because the defaults depend on the underlying mount point. These methods need counterparts that accept a {{Path}} so viewfs can resolve the mount point for a path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira