You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/25 07:16:32 UTC

[GitHub] [airflow-client-python] 11010cy opened a new pull request #42: Fix wrong use of $ref and nullable

11010cy opened a new pull request #42:
URL: https://github.com/apache/airflow-client-python/pull/42


   ### Composed schemas `$ref` and `nullable` are not supported. And inline composed schemas has bug using tooling.
   
   > Per the openapi spec, properties adjacent to refs are ignored:
   https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.1.0.md#reference-object
   This object cannot be extended with additional properties and any properties added SHALL be ignored. except for summary and description.
   
   ```
   dag_run_timeout:
                 nullable: true
                 $ref: '#/components/schemas/TimeDelta'
   ```
   
   ```
   dag_run_timeout:
    oneOf:
     - type: null
     - $ref: '#/components/schemas/TimeDelta'
   ```
   
   All the above definitions are **not correct**.
   
   **related issues:**
   [OpenAPITools/openapi-generator/issues/11352](https://github.com/OpenAPITools/openapi-generator/issues/11352)
   [apache/airflow-client-python/issues/40](https://github.com/apache/airflow-client-python/issues/40)
   
   **[airflow]**
   **related prs**
   pr:[apache/airflow/pull/21080](https://github.com/apache/airflow/pull/21080)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org