You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/04/05 18:42:38 UTC

Review Request: Updated resource offers tests to use new testing abstractions.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10306/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Description
-------

See summary.


Diffs
-----

  src/tests/resource_offers_tests.cpp 53b92abbdfb67e9bf09f7d100f1c7995164c4132 

Diff: https://reviews.apache.org/r/10306/diff/


Testing
-------

./bin/mesos-tests.sh --gtest_filter=ResourceOffersTest.* --gtest_repeat=1000


Thanks,

Benjamin Hindman


Re: Review Request: Updated resource offers tests to use new testing abstractions.

Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10306/#review18986
-----------------------------------------------------------

Ship it!


Ship it!

- Thomas Marshall


On April 5, 2013, 5:42 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10306/
> -----------------------------------------------------------
> 
> (Updated April 5, 2013, 5:42 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/resource_offers_tests.cpp 53b92abbdfb67e9bf09f7d100f1c7995164c4132 
> 
> Diff: https://reviews.apache.org/r/10306/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --gtest_filter=ResourceOffersTest.* --gtest_repeat=1000
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: Updated resource offers tests to use new testing abstractions.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10306/#review18958
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On April 5, 2013, 5:42 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10306/
> -----------------------------------------------------------
> 
> (Updated April 5, 2013, 5:42 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/resource_offers_tests.cpp 53b92abbdfb67e9bf09f7d100f1c7995164c4132 
> 
> Diff: https://reviews.apache.org/r/10306/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --gtest_filter=ResourceOffersTest.* --gtest_repeat=1000
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request: Updated resource offers tests to use new testing abstractions.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10306/
-----------------------------------------------------------

(Updated April 5, 2013, 5:42 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Fixed bug uncovered from 1000 runs.


Description
-------

See summary.


Diffs (updated)
-----

  src/tests/resource_offers_tests.cpp 53b92abbdfb67e9bf09f7d100f1c7995164c4132 

Diff: https://reviews.apache.org/r/10306/diff/


Testing
-------

./bin/mesos-tests.sh --gtest_filter=ResourceOffersTest.* --gtest_repeat=1000


Thanks,

Benjamin Hindman