You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/04 16:49:25 UTC
[GitHub] [incubator-dolphinscheduler] elonlo opened a new pull request
#1717: Refactor Alert module #1694
elonlo opened a new pull request #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717
## What is the purpose of the pull request
Refactor Alert module
*Step 1: define the Sender interface, use JAVA SPI to decouple the sender logic, and support the registration of alarm plugins.*
## Brief change log
- *Add powermock to alert pom.xml*
- *Add sender package to module*
## Verify this pull request
This change added tests and can be verified as follows:
- *Added EmailSenderTest to verify the change.*
- *Added SenderManagerTest to verify the change.*
- *Added ShortMessageServiceSenderTest to verify the change.*
- *Added AlertExceptionTest to verify the change.*
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1717: Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#issuecomment-570801224
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=h1) Report
> Merging [#1717](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1f7db8f7975d2d01048eaaeae98d4425417abbae?src=pr&el=desc) will **increase** coverage by `0.49%`.
> The diff coverage is `47.05%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1717 +/- ##
==========================================
+ Coverage 17.48% 17.98% +0.49%
==========================================
Files 285 286 +1
Lines 13912 13969 +57
Branches 2274 2282 +8
==========================================
+ Hits 2433 2512 +79
+ Misses 11206 11173 -33
- Partials 273 284 +11
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...heduler/alert/manager/EnterpriseWeChatManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9tYW5hZ2VyL0VudGVycHJpc2VXZUNoYXRNYW5hZ2VyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...eduler/alert/sender/ShortMessageServiceSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvU2hvcnRNZXNzYWdlU2VydmljZVNlbmRlci5qYXZh) | `44.44% <44.44%> (ø)` | |
| [...e/dolphinscheduler/alert/sender/SenderManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvU2VuZGVyTWFuYWdlci5qYXZh) | `57.14% <57.14%> (ø)` | |
| [.../apache/dolphinscheduler/alert/AlertException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydEV4Y2VwdGlvbi5qYXZh) | `62.5% <62.5%> (ø)` | |
| [...che/dolphinscheduler/alert/sender/EmailSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvRW1haWxTZW5kZXIuamF2YQ==) | `72.97% <72.97%> (ø)` | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=footer). Last update [1f7db8f...e0786e3](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1717:
Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#issuecomment-570801224
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=h1) Report
> Merging [#1717](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1f7db8f7975d2d01048eaaeae98d4425417abbae?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1717 +/- ##
==========================================
- Coverage 17.48% 17.41% -0.08%
==========================================
Files 285 286 +1
Lines 13912 13969 +57
Branches 2274 2282 +8
==========================================
Hits 2433 2433
- Misses 11206 11263 +57
Partials 273 273
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../apache/dolphinscheduler/alert/AlertException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydEV4Y2VwdGlvbi5qYXZh) | `0% <0%> (ø)` | |
| [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...che/dolphinscheduler/alert/sender/EmailSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvRW1haWxTZW5kZXIuamF2YQ==) | `0% <0%> (ø)` | |
| [...heduler/alert/manager/EnterpriseWeChatManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9tYW5hZ2VyL0VudGVycHJpc2VXZUNoYXRNYW5hZ2VyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...eduler/alert/sender/ShortMessageServiceSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvU2hvcnRNZXNzYWdlU2VydmljZVNlbmRlci5qYXZh) | `0% <0%> (ø)` | |
| [...e/dolphinscheduler/alert/sender/SenderManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvU2VuZGVyTWFuYWdlci5qYXZh) | `0% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=footer). Last update [1f7db8f...e24c08d](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in
pull request #1717: Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#discussion_r363078185
##########
File path: dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -73,4 +76,37 @@ public static void main(String[] args){
alertServer.start();
}
+ /**
+ * send alert message
+ * @param alerts waiting list
+ */
+ private void send(List<Alert> alerts) {
Review comment:
Suggestion:
AlerServer should not has this send, put it to other class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] elonlo removed a comment on issue
#1717: Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
elonlo removed a comment on issue #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#issuecomment-570894799
> We should use zk lock to let AlertServer in a distribute mode , right ?
> @qiaozhanwei @dailidong
my idea is to make AlertServer a basic jar package without distributed logic. which service needs to send an alert, add a dependency in the pom file and then call the alert api
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] elonlo commented on issue #1717:
Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
elonlo commented on issue #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#issuecomment-570894825
> We should use zk lock to let AlertServer in a distribute mode , right ?
> @qiaozhanwei @dailidong
my idea is to make AlertServer a basic jar package without distributed logic. which service needs to send an alert, add a dependency in the pom file and then call the alert api
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#1717: Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#issuecomment-571964729
SonarCloud Quality Gate failed.
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1717&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1717&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1717&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1717&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1717&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1717&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1717&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1717&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1717&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1717&resolved=false&types=CODE_SMELL) [14 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1717&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60.png' alt='62.6%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1717&metric=new_coverage&view=list) [62.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1717&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1717&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1717&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] elonlo commented on issue #1717:
Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
elonlo commented on issue #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#issuecomment-570894799
> We should use zk lock to let AlertServer in a distribute mode , right ?
> @qiaozhanwei @dailidong
my idea is to make AlertServer a basic jar package without distributed logic. which service needs to send an alert, add a dependency in the pom file and then call the alert api
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] elonlo commented on a change in pull
request #1717: Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
elonlo commented on a change in pull request #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#discussion_r363081179
##########
File path: dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -73,4 +76,37 @@ public static void main(String[] args){
alertServer.start();
}
+ /**
+ * send alert message
+ * @param alerts waiting list
+ */
+ private void send(List<Alert> alerts) {
Review comment:
yes, I want to remove the logic of regularly scanning the DB in the second step and then decouple the AlertServer class and the Send method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in
pull request #1717: Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#discussion_r363078185
##########
File path: dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -73,4 +76,37 @@ public static void main(String[] args){
alertServer.start();
}
+ /**
+ * send alert message
+ * @param alerts waiting list
+ */
+ private void send(List<Alert> alerts) {
Review comment:
Suggestion:
AlertServer should not has this send, put it to other class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- commented on a change in
pull request #1717: Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on a change in pull request #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#discussion_r363568060
##########
File path: dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -73,4 +76,37 @@ public static void main(String[] args){
alertServer.start();
}
+ /**
+ * send alert message
+ * @param alerts waiting list
+ */
+ private void send(List<Alert> alerts) {
Review comment:
> yes, I want to remove the logic of regularly scanning the DB in the second step and then decouple the AlertServer class and the Send method.
Merging your pr will affect all the developer. Even though refactor can split into more steps, but every step should code nice .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] elonlo commented on a change in pull
request #1717: Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
elonlo commented on a change in pull request #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#discussion_r364035373
##########
File path: dolphinscheduler-alert/src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java
##########
@@ -73,4 +76,37 @@ public static void main(String[] args){
alertServer.start();
}
+ /**
+ * send alert message
+ * @param alerts waiting list
+ */
+ private void send(List<Alert> alerts) {
Review comment:
hmm, I will abstract the Send function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] elonlo closed pull request #1717:
Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
elonlo closed pull request #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1717: Refactor Alert module #1694
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1717: Refactor Alert module #1694
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1717#issuecomment-570801224
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=h1) Report
> Merging [#1717](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/03ef3943997f43de8c5bc06810bff4e284f6401e?src=pr&el=desc) will **increase** coverage by `0.62%`.
> The diff coverage is `57.85%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1717 +/- ##
==========================================
+ Coverage 20.22% 20.85% +0.62%
==========================================
Files 290 292 +2
Lines 14082 14141 +59
Branches 2376 2382 +6
==========================================
+ Hits 2848 2949 +101
+ Misses 10908 10856 -52
- Partials 326 336 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...heduler/alert/manager/EnterpriseWeChatManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9tYW5hZ2VyL0VudGVycHJpc2VXZUNoYXRNYW5hZ2VyLmphdmE=) | `7.14% <100%> (+7.14%)` | :arrow_up: |
| [...r/alert/sender/impl/ShortMessageServiceSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvaW1wbC9TaG9ydE1lc3NhZ2VTZXJ2aWNlU2VuZGVyLmphdmE=) | `44.44% <44.44%> (ø)` | |
| [.../dolphinscheduler/alert/AlertDispatchExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydERpc3BhdGNoRXhlY3V0b3IuamF2YQ==) | `48.14% <48.14%> (ø)` | |
| [...e/dolphinscheduler/alert/sender/SenderManager.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvU2VuZGVyTWFuYWdlci5qYXZh) | `58.82% <58.82%> (ø)` | |
| [.../apache/dolphinscheduler/alert/AlertException.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydEV4Y2VwdGlvbi5qYXZh) | `62.5% <62.5%> (ø)` | |
| [...olphinscheduler/alert/sender/impl/EmailSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9zZW5kZXIvaW1wbC9FbWFpbFNlbmRlci5qYXZh) | `72.97% <72.97%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=footer). Last update [03ef394...fcc61ee](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1717?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services