[jira] Commented: (NUTCH-393) Indexer doesn't handle null documents returned by filters

["Andrzej Bialecki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494552 ] 

Andrzej Bialecki  commented on NUTCH-393:
-----------------------------------------

I agree with that - either all filters should run or the document should be discarded. If it's acceptable to tolerate exceptions in some indexing filters, such exceptions should be caught there.

> Indexer doesn't handle null documents returned by filters
> ---------------------------------------------------------
>
>                 Key: NUTCH-393
>                 URL: https://issues.apache.org/jira/browse/NUTCH-393
>             Project: Nutch
>          Issue Type: Bug
>          Components: indexer
>    Affects Versions: 0.8.1, 0.9.0
>            Reporter: Eelco Lempsink
>         Attachments: NUTCH-393.patch
>
>
> Plugins (like IndexingFilter) may return a null value, but this isn't handled by the Indexer.  A trivial adjustment is all it takes:
> @@ -237,6 +237,7 @@
>        if (LOG.isWarnEnabled()) { LOG.warn("Error indexing "+key+": "+e); }
>        return;
>      }
> +    if (doc == null) return;
>  
>      float boost = 1.0f;
>      // run scoring filters

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.