[Impala-ASF-CR] IMPALA-8065 Edit OS version and Kernel version in OSInfo

["Andrew Sherman (Code Review)" <ge...@cloudera.org>]

Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/14531 )

Change subject: IMPALA-8065 Edit OS version and Kernel version in OSInfo
......................................................................


Patch Set 6:

(2 comments)

Still a few things to think about...

http://gerrit.cloudera.org:8080/#/c/14531/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14531/6//COMMIT_MSG@7
PS6, Line 7: IMPALA-8065 Edit OS version and Kernel version in OSInfo
Can you improve this one line description? Why is it Edit?


http://gerrit.cloudera.org:8080/#/c/14531/6/be/src/util/os-info.cc
File be/src/util/os-info.cc:

http://gerrit.cloudera.org:8080/#/c/14531/6/be/src/util/os-info.cc@72
PS6, Line 72:       if (fields[0].compare("PRETTY_NAME") == 0) {
Will this work on Centos6?
https://www.liquidweb.com/kb/how-to-check-your-centos-version/



-- 
To view, visit http://gerrit.cloudera.org:8080/14531
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I848c9e53ee4e0bf8ae0874bb6da28e8efa7f7c8a
Gerrit-Change-Number: 14531
Gerrit-PatchSet: 6
Gerrit-Owner: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Xiaomeng Zhang <xi...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Nov 2019 18:08:07 +0000
Gerrit-HasComments: Yes