You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by Ethanlm <gi...@git.apache.org> on 2017/07/19 21:02:28 UTC

[GitHub] storm pull request #2230: [STORM-2644] Show message when result not found on...

GitHub user Ethanlm opened a pull request:

    https://github.com/apache/storm/pull/2230

    [STORM-2644] Show message when result not found on deep search page

    Deep search shows a blank area if no results are found.
    
    ![image](https://user-images.githubusercontent.com/14900612/28389389-82e92d84-6c9b-11e7-9594-8e9690e22724.png)
    
    Show some message to avoid confusion about whether the searching is finished or not.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ethanlm/storm STORM-2644

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2230
    
----
commit f1145b272fc3bfd005b9f0e576fbdb8ae1843460
Author: Ethan Li <et...@gmail.com>
Date:   2017-07-19T20:57:02Z

    [STORM-2644] Show message when result not found on deep search page

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2230: [STORM-2644] Show message when result not found on deep s...

Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:

    https://github.com/apache/storm/pull/2230
  
    Thanks. Will fix it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2230: [STORM-2644] Show message when result not found on...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2230


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2230: [STORM-2644] Show message when result not found on deep s...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2230
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2230: [STORM-2644] Show message when result not found on deep s...

Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:

    https://github.com/apache/storm/pull/2230
  
    Addressed comment from @knusbaum . 
    Tested some simple cases on firefox, chrome and safari. The following screenshots are from testing on firefox.
    ![onlyon6702](https://user-images.githubusercontent.com/14900612/28425598-654cf5d0-6d36-11e7-8f25-71449922f6b8.png)
    ![onlyon6703](https://user-images.githubusercontent.com/14900612/28425602-67de6dba-6d36-11e7-80e9-7980ba698f8d.png)
    ![notanywhere](https://user-images.githubusercontent.com/14900612/28425608-6a0f01da-6d36-11e7-8a19-007796b7d33a.png)
    ![onbothworkers](https://user-images.githubusercontent.com/14900612/28425614-6c1cefbe-6d36-11e7-8b06-36087f1f31d9.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2230: [STORM-2644] Show message when result not found on deep s...

Posted by Ethanlm <gi...@git.apache.org>.
Github user Ethanlm commented on the issue:

    https://github.com/apache/storm/pull/2230
  
    ![image](https://user-images.githubusercontent.com/14900612/28389361-69561454-6c9b-11e7-8cd2-7f5aeafa373f.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2230: [STORM-2644] Show message when result not found on deep s...

Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the issue:

    https://github.com/apache/storm/pull/2230
  
    I would prefer *one* message if nothing is found. When there are hundreds of workers, this would make users scroll through many "Result not found" messages before getting to results that *are* returned.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---