[jira] [Commented] (AIRFLOW-4528) DataProcOperators do not stop underlying jobs on timeout

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842122#comment-16842122 ] 

ASF GitHub Bot commented on AIRFLOW-4528:
-----------------------------------------

AlexisBRENON commented on pull request #5293: [AIRFLOW-4528] Cancel DataProc task on timeout
URL: https://github.com/apache/airflow/pull/5293
 
 
   Make sure you have checked all steps below.
   
   ### Jira
   
   - [x] My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4528
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
     - My PR factorize code for most DataProcXXXOperator operators and primarily implements the `on_kill` callback to cancel dataproc launched jobs on timeout.
   
   ### Tests
   
   - [x] My PR adds the following unit tests **OR** does not need testing for this extremely good reason:
     - My PR adds the `DataProcJobBaseOperatorTest` to test that the `on_kill` method is called. I cannot manage to execute the tests locally (which deps, commands ?).
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
     i. Subject is separated from body by a blank line
     ii. Subject is limited to 50 characters (not including Jira issue reference)
     iii. Subject does not end with a period
     iv. Subject uses the imperative mood ("add", not "adding")
     v. Body wraps at 72 characters
     vi. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes flake8
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> DataProcOperators do not stop underlying jobs on timeout
> --------------------------------------------------------
>
>                 Key: AIRFLOW-4528
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4528
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: operators
>    Affects Versions: 1.10.3
>            Reporter: Alexis BRENON
>            Assignee: Alexis BRENON
>            Priority: Major
>
> When using DataProcOperators (like DataProcSparkOperator) with a specified `execution_timeout`, the DAG task is actually marked as failed and retry after the timeout, but the underlying job is not stopped.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)