You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "James Taylor (JIRA)" <ji...@apache.org> on 2016/01/06 07:47:39 UTC

[jira] [Commented] (PHOENIX-2357) Prevent queries from failing because of scanners running into lease expiration

    [ https://issues.apache.org/jira/browse/PHOENIX-2357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15085069#comment-15085069 ] 

James Taylor commented on PHOENIX-2357:
---------------------------------------

Looks good, [~samarthjain]. Nice work. One minor nit - why not just name this constant the same and just change the value in each of the branches to reduce merge issues going forward?
{code}
+    public static final int MIN_RENEW_LEASE_HBASE_1_X_VERSION = VersionUtil.encodeVersion("1", "1", "4");
{code}
Once you optionally don't wrap the table iterator with the spooling and chunking iterators, we'll want to perf test this. Any sense on perf now?

> Prevent queries from failing because of scanners running into lease expiration
> ------------------------------------------------------------------------------
>
>                 Key: PHOENIX-2357
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2357
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-2357_4.x-HBase-0.98.patch, PHOENIX-2357_4.x-HBase-1.0.patch, PHOENIX-2357_master.patch, PHOENIX-2357_wip.patch, PHOENIX-2357_wip2.patch, PHOENIX-2357_wip3.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)