You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2016/03/09 21:46:31 UTC
[GitHub] couchdb-fauxton pull request: QueryButtons component now passed cl...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/664
QueryButtons component now passed close handler
Needed to be able to reuse the component elsewhere.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton query-buttons-update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/664.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #664
----
commit edc093ca8b3375747b710e4115317ed734eba209
Author: Ben Keen <be...@gmail.com>
Date: 2016-03-09T20:36:54Z
QueryButtons component now passed close handler
Needed to be able to reuse the component elsewhere.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: QueryButtons component now passed cl...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/664#issuecomment-199403881
Thanks, Ryan. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: QueryButtons component now passed cl...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: QueryButtons component now passed cl...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/664#discussion_r56734795
--- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx ---
@@ -343,6 +347,10 @@ A key value is the first parameter emitted in a map function. For example emit("
Actions.toggleQueryBarVisibility(!this.props.contentVisible);
},
+ closeTray: function () {
+ Actions.toggleQueryBarVisibility(false);
--- End diff --
Those are actually okay. The other occurrences of that method are specific to the standard query tray used in Fauxton, so that's fine: they can keep their own event handler.
This ticket's just so I can re-use the QueryButtons component elsewhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: QueryButtons component now passed cl...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/664#issuecomment-200130949
Merged as aa52e40d432ecaeeaf04e31ed2597efd6d51078c
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: QueryButtons component now passed cl...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/664#discussion_r55817171
--- Diff: app/addons/documents/queryoptions/queryoptions.react.jsx ---
@@ -343,6 +347,10 @@ A key value is the first parameter emitted in a map function. For example emit("
Actions.toggleQueryBarVisibility(!this.props.contentVisible);
},
+ closeTray: function () {
+ Actions.toggleQueryBarVisibility(false);
--- End diff --
question: there are a few other occurences, like https://github.com/apache/couchdb-fauxton/pull/664/files#diff-a9b641a64002ae88871f5b368a99f1beL351 -- i think we have to replace them, too in order to make the callbacks called uniform?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: QueryButtons component now passed cl...
Posted by millayr <gi...@git.apache.org>.
Github user millayr commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/664#issuecomment-199403664
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---