You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/02/25 20:09:11 UTC

[GitHub] [calcite] julianhyde commented on a change in pull request #2357: [CALCITE-4446] Implement three-valued logic for SEARCH operator

julianhyde commented on a change in pull request #2357:
URL: https://github.com/apache/calcite/pull/2357#discussion_r583131959



##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -2840,8 +2829,8 @@ static RexNode fix(RexBuilder rexBuilder, RexNode term) {
 
     @Override public String toString() {
       return "SEARCH(" + ref + ", " + (negate ? "NOT " : "") + rangeSet
-          + ", " + (nullTermCount + notNullTermCount)
-          + " terms of which " + nullTermCount + " allow null)";
+          + ", " + (nullAsTrueCount + nullAsFalseCount)
+          + " terms of which " + nullAsTrueCount + " allow null)";

Review comment:
       yes, I can improve this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org