You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by jaikiran <gi...@git.apache.org> on 2017/05/23 09:03:28 UTC
[GitHub] ant-ivy pull request #27: Fix IVY-1540
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant-ivy/pull/27
Fix IVY-1540
The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1540. The dependency tree task now takes into account any potential circular dependencies that could result into a indefinite recursive calls.
This also includes a test case to verify such a use case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/ant-ivy ivy-1540
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant-ivy/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 6cb32bd33e0e1d1758a3ed1d50df03b65032d9ac
Author: Jaikiran Pai <ja...@gmail.com>
Date: 2017-05-23T08:15:39Z
IVY-1540 Fix infinite loop in dependencytree, caused to due circular dependencies (coming in via Maven module descriptors)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy pull request #27: Fix IVY-1540
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran closed the pull request at:
https://github.com/apache/ant-ivy/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy pull request #27: Fix IVY-1540
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran closed the pull request at:
https://github.com/apache/ant-ivy/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy issue #27: Fix IVY-1540
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/27
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy pull request #27: Fix IVY-1540
Posted by jaikiran <gi...@git.apache.org>.
GitHub user jaikiran reopened a pull request:
https://github.com/apache/ant-ivy/pull/27
Fix IVY-1540
The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1540. The dependency tree task now takes into account any potential circular dependencies that could result into a indefinite recursive calls.
This also includes a test case to verify such a use case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/ant-ivy ivy-1540
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant-ivy/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 6cb32bd33e0e1d1758a3ed1d50df03b65032d9ac
Author: Jaikiran Pai <ja...@gmail.com>
Date: 2017-05-23T08:15:39Z
IVY-1540 Fix infinite loop in dependencytree, caused to due circular dependencies (coming in via Maven module descriptors)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy pull request #27: Fix IVY-1540
Posted by jaikiran <gi...@git.apache.org>.
GitHub user jaikiran reopened a pull request:
https://github.com/apache/ant-ivy/pull/27
Fix IVY-1540
The commit here fixes the issue reported in https://issues.apache.org/jira/browse/IVY-1540. The dependency tree task now takes into account any potential circular dependencies that could result into a indefinite recursive calls.
This also includes a test case to verify such a use case.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/ant-ivy ivy-1540
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant-ivy/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 6cb32bd33e0e1d1758a3ed1d50df03b65032d9ac
Author: Jaikiran Pai <ja...@gmail.com>
Date: 2017-05-23T08:15:39Z
IVY-1540 Fix infinite loop in dependencytree, caused to due circular dependencies (coming in via Maven module descriptors)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy issue #27: Fix IVY-1540
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/27
I forgot to include a sample of how the circular dependency is now going to be reported in the dependency tree output. Here's a sample of it:
```
[ivy:dependencytree] \- org.apache.xmlgraphics#batik-bridge;1.7
[ivy:dependencytree] | +- org.apache.xmlgraphics#batik-anim;1.7
[ivy:dependencytree] | | +- org.apache.xmlgraphics#batik-awt-util;1.7
[ivy:dependencytree] | | \- org.apache.xmlgraphics#batik-util;1.7
[ivy:dependencytree] | | +- org.apache.xmlgraphics#batik-dom;1.7
[ivy:dependencytree] | | | +- org.apache.xmlgraphics#batik-css;1.7
[ivy:dependencytree] | | | | +- org.apache.xmlgraphics#batik-ext;1.7
[ivy:dependencytree] | | | | \- xml-apis#xml-apis;1.3.04
[ivy:dependencytree] | | | | +- org.apache.xmlgraphics#batik-util;1.7
[ivy:dependencytree] | | | | +- xml-apis#xml-apis;1.3.04
[ivy:dependencytree] | | | \- xml-apis#xml-apis-ext;1.3.04
[ivy:dependencytree] | | | +- org.apache.xmlgraphics#batik-ext;1.7
[ivy:dependencytree] | | | \- xml-apis#xml-apis;1.3.04
[ivy:dependencytree] | | | +- org.apache.xmlgraphics#batik-util;1.7
[ivy:dependencytree] | | | +- org.apache.xmlgraphics#batik-xml;1.7
[ivy:dependencytree] | | | \- org.apache.xmlgraphics#batik-util;1.7
[ivy:dependencytree] | | | +- xalan#xalan;2.6.0
[ivy:dependencytree] | | | | +- xml-apis#xml-apis;1.3.04
[ivy:dependencytree] | | | +- xml-apis#xml-apis;1.3.04
[ivy:dependencytree] | | \- xml-apis#xml-apis-ext;1.3.04
[ivy:dependencytree] | | +- org.apache.xmlgraphics#batik-ext;1.7
[ivy:dependencytree] | | \- xml-apis#xml-apis;1.3.04
[ivy:dependencytree] | | +- org.apache.xmlgraphics#batik-parser;1.7
[ivy:dependencytree] | | | +- org.apache.xmlgraphics#batik-awt-util;1.7
[ivy:dependencytree] | | | \- org.apache.xmlgraphics#batik-util;1.7
[ivy:dependencytree] | | | +- org.apache.xmlgraphics#batik-util;1.7
[ivy:dependencytree] | | | \- org.apache.xmlgraphics#batik-xml;1.7
[ivy:dependencytree] | | | \- org.apache.xmlgraphics#batik-util;1.7
[ivy:dependencytree] | | +- org.apache.xmlgraphics#batik-svg-dom;1.7
[ivy:dependencytree] | | | +- (circularly depends on) org.apache.xmlgraphics#batik-anim;1.7
....
....
```
Notice the last couple of lines in the snippet which reports a circular dependency in the output.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy pull request #27: Fix IVY-1540
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/ant-ivy/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant-ivy issue #27: Fix IVY-1540
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant-ivy/pull/27
Now that the transient failure fixes have been merged and the Jenkins PR jobs are working, going to reopen this to trigger a new run of Jenkins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org