[GitHub] liubao68 closed pull request #748: [SCB-471]watch mode: netty upgrade have add pong response and need to handle it

[GitBox <gi...@apache.org>]

liubao68 closed pull request #748: [SCB-471]watch mode: netty upgrade have add pong response and need to handle it
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/748
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java b/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
index 9941a27de..a58de4da2 100644
--- a/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
+++ b/dynamic-config/config-cc/src/main/java/org/apache/servicecomb/config/client/ConfigCenterClient.java
@@ -63,6 +63,7 @@
 import io.vertx.core.DeploymentOptions;
 import io.vertx.core.Vertx;
 import io.vertx.core.VertxOptions;
+import io.vertx.core.buffer.Buffer;
 import io.vertx.core.http.CaseInsensitiveHeaders;
 import io.vertx.core.http.HttpClientOptions;
 import io.vertx.core.http.HttpClientRequest;
@@ -292,7 +293,12 @@ public void doWatch(String configCenter)
                 stopHeartBeatThread();
                 isWatching = false;
               });
-              ws.handler(action -> {
+
+              ws.pongHandler(pong -> {
+                // ignore, just prevent NPE.
+              });
+              ws.frameHandler(frame -> {
+                Buffer action = frame.binaryData();
                 LOGGER.info("watching config recieved {}", action);
                 Map<String, Object> mAction = action.toJsonObject().getMap();
                 if ("CREATE".equals(mAction.get("action"))) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services