You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/23 23:09:36 UTC

[GitHub] [kafka] vvcephei commented on a change in pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

vvcephei commented on a change in pull request #8540:
URL: https://github.com/apache/kafka/pull/8540#discussion_r414182534



##########
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##########
@@ -161,6 +165,9 @@ public void before() throws Exception {
         props.put(StreamsConfig.STATE_DIR_CONFIG, TestUtils.tempDirectory().getPath());
         props.put(StreamsConfig.NUM_STREAM_THREADS_CONFIG, NUM_THREADS);
 
+        builder = new StreamsBuilder();
+        builder.stream("source");

Review comment:
       Can you create a method to `getBuilderWithSource()` and just call it inline instead of creating a new mutable field for all the tests to rely on?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org