[jira] [Commented] (SCB-582) Provide a way to protection for instance removal

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475811#comment-16475811 ] 

ASF GitHub Bot commented on SCB-582:
------------------------------------

liubao68 opened a new pull request #704: [SCB-582]Provide a way to protect instance removal
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/704
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Provide a way to protection for instance removal
> ------------------------------------------------
>
>                 Key: SCB-582
>                 URL: https://issues.apache.org/jira/browse/SCB-582
>             Project: Apache ServiceComb
>          Issue Type: New Feature
>          Components: Java-Chassis
>            Reporter: liubao
>            Assignee: liubao
>            Priority: Major
>
> In some applications, each microservice have fixed instances and rarely change. But for some reason, heartbeat to service center is not stable. In this scenario, instances will get lost and result in invocation failure. 
>  
> To deal with this problem, we need to provide a way to protect instance removal. That's when there is instance removal, we first check(ping)the instance to see if it is reachable. If it's reachable, we don't remove it. 
>  
> Since this protection is not fit for docker applications or scenarios where instances are constantly removed and added, and resources(hosts ,ip, port) are reused, this feature is an optional feature and users can open it when necessary. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)