[jira] [Commented] (DOXIA-588) The Sink.JUSTIFY_XXX has no effect

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DOXIA-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351742#comment-17351742 ] 

ASF GitHub Bot commented on DOXIA-588:
--------------------------------------

elharo commented on a change in pull request #61:
URL: https://github.com/apache/maven-doxia/pull/61#discussion_r639660055



##########
File path: .github/workflows/maven.yml
##########
@@ -0,0 +1,44 @@
+ # Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       This should be in a separate PR as it's not directly related to fixing this bug

##########
File path: doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java
##########
@@ -1658,6 +1659,35 @@ public void tableHeaderCell( SinkEventAttributes attributes )
     private void tableCell( boolean headerRow, MutableAttributeSet attributes )
     {
         Tag t = ( headerRow ? HtmlMarkup.TH : HtmlMarkup.TD );
+        
+        if (   !headerRow 
+            && null != this.cellCountStack

Review comment:
       this.foo != null
   is far more common and unsurprising. Putting the literal first is a C convention not needed in Java.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> The Sink.JUSTIFY_XXX has no effect
> ----------------------------------
>
>                 Key: DOXIA-588
>                 URL: https://issues.apache.org/jira/browse/DOXIA-588
>             Project: Maven Doxia
>          Issue Type: Bug
>            Reporter: QualiteSys QualiteSys
>            Assignee: Michael Osipov
>            Priority: Minor
>
> Hello
> I wish to use custom column alignments in tables.
> The Sink.JUSTIFY_LEFT or RIGHT seams not working.
>  
> Is this code valid ?
> {code:java}  sink.table();
>   int[] j = {       
>      Sink.JUSTIFY_LEFT,
>      Sink.JUSTIFY_RIGHT
>    };
>   sink.tableRows(j, true);{code}
> I haven't found examples up to now.
> Thanks for your help
> Didier



--
This message was sent by Atlassian Jira
(v8.3.4#803005)