You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/11/18 01:24:52 UTC

[GitHub] [samza] MabelYC commented on pull request #1437: SAMZA-2598:Kafka clients are not created and closed properly

MabelYC commented on pull request #1437:
URL: https://github.com/apache/samza/pull/1437#issuecomment-729315648


   > I don't like using finalize() in objects. We ran into huge GC issues because of it in the past.
   > You can search google for this topic (e.g. https://howtodoinjava.com/java-examples/why-not-to-use-finalize-method-in-java/).
   > Please consider alternative solutions.
   
   Changed to use addShutdownHook to close clients. Please take a look.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org