You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ramkrish86 <gi...@git.apache.org> on 2017/04/24 10:36:52 UTC

[GitHub] flink pull request #3760: FLINK-5752 Support push down projections for HBase...

GitHub user ramkrish86 opened a pull request:

    https://github.com/apache/flink/pull/3760

    FLINK-5752 Support push down projections for HBaseTableSource (Ram)

    Ran mvn clean verify -DskipTests
    In this patch 
    `Arrays.sort(nestedFields[i]);`
    
    Am doing this before doing addColumns for the new projected table source, because here the cols appears in a reverse sorted way and when we apply that for the new projected table source it creates an assertion error while creating the new calcite program with the projected cols
    `assert expr.getType().getFieldList().get(field.getIndex()) == field;`
    So doing this sort helps in correcting those issues and the tests run fine. But this nestedFields that is being passed to the projectNestedFields() API is created by
    `def getProjectedFields: Array[Array[String]] ` under RexProgramExtractor. Trying to understand what it does. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ramkrish86/flink FLINK-5752

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3760.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3760
    
----
commit 1885b0c9afc7aa49747987b0508ba82002a1bc8d
Author: Ramkrishna <ra...@intel.com>
Date:   2017-04-24T10:23:08Z

    FLINK-5752 Support push down projections for HBaseTableSource (Ram)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the issue:

    https://github.com/apache/flink/pull/3760
  
    The failures seems not directly related.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/3760
  
    Hi @ramkrish86,
    I'm currently very busy getting the last changes for some bigger features in before the feature freeze for Flink 1.3. Can't promise that I'll have time to look at this before the release branch is forked off.
    
    Best, Fabian


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the issue:

    https://github.com/apache/flink/pull/3760
  
    @fhueske , @tonycox 
    Can you have a look at this PR? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the issue:

    https://github.com/apache/flink/pull/3760
  
    @fhueske 
    Thanks for the update. Got it.
    But I would like to say that if there any issues/JIRA that I could be of help for the 1.3 release fork, I would happy to help. Pls point me to those you think I can be of help, I can have a look and commit to what ever I can spend time on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the issue:

    https://github.com/apache/flink/pull/3760
  
    I checked the recent failure.
    `Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 20.417 sec <<< FAILURE! - in org.apache.flink.runtime.jobmanager.JobManagerRegistrationTest`
    
    This failure seems unrelated with the changes in this patch.
    @tonycox , @fhueske 
    Just a gentle ping.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

Posted by tonycox <gi...@git.apache.org>.
Github user tonycox commented on the issue:

    https://github.com/apache/flink/pull/3760
  
    @ramkrish86 Hi, Thank you for the PR. Could you repush commit?
    ```
    git commit --amend
    gut push origin FLINK-5752 -f
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the issue:

    https://github.com/apache/flink/pull/3760
  
    @fhueske 
    Do you have some time to check this now considering Flink - 1.3 release is out?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

Posted by ramkrish86 <gi...@git.apache.org>.
Github user ramkrish86 commented on the issue:

    https://github.com/apache/flink/pull/3760
  
    @tonycox 
    Thanks for the comment? Just curious. Any reason for the repush - is it for checking the test failures again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---