[GitHub] [arrow] edponce commented on a change in pull request #12517: ARROW-15455: [C++] Cast between fixed size list type and variable size list

[GitBox <gi...@apache.org>]

edponce commented on a change in pull request #12517:
URL: https://github.com/apache/arrow/pull/12517#discussion_r818100195



##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_nested.cc
##########
@@ -84,6 +84,13 @@ struct CastList {
                                                       options, ctx->exec_context()));
 
         out_scalar->is_valid = true;
+
+        if (is_fixed_size_list_type<DestType>::value) {

Review comment:
       Normally, we do not use SFINAE aliases for declarative runtime checks
   ```c++
   if (out_scalar->type->id() == Type::FIXED_SIZE_LIST) { ... }
   ```
   
   Nevertheless, the code is not reaching the Scalar block (from pyarrow) bc Scalar cast does not works (see [JIRA comment](https://issues.apache.org/jira/browse/ARROW-15455?focusedCommentId=17500385&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17500385)).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org