You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "l0kr (via GitHub)" <gi...@apache.org> on 2023/03/26 11:13:04 UTC
[GitHub] [arrow-datafusion] l0kr opened a new pull request, #5742: Move protoc generation to binary crate (#5718)
l0kr opened a new pull request, #5742:
URL: https://github.com/apache/arrow-datafusion/pull/5742
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #5718
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5742: Move protoc generation to binary crate (#5718)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5742:
URL: https://github.com/apache/arrow-datafusion/pull/5742#discussion_r1149767665
##########
datafusion/proto/Cargo.toml:
##########
@@ -54,8 +54,3 @@ serde_json = { version = "1.0", optional = true }
[dev-dependencies]
doc-comment = "0.3"
tokio = "1.18"
-
-[build-dependencies]
-# Pin these dependencies so that the generated output is deterministic
Review Comment:
🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5742: Move protoc generation to binary crate (#5718)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5742:
URL: https://github.com/apache/arrow-datafusion/pull/5742#issuecomment-1485846054
I verified this works great -- https://github.com/apache/arrow-datafusion/pull/5760#issue-1642777613
Thanks @tustvold and @l0kr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5742: Move protoc generation to binary crate (#5718)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5742:
URL: https://github.com/apache/arrow-datafusion/pull/5742#discussion_r1149639670
##########
.github/workflows/rust.yml:
##########
@@ -320,6 +320,20 @@ jobs:
- name: Run datafusion-common tests
run: cargo test -p datafusion-common --features=pyarrow
+ vendor:
+ name: Verify Vendored Code
+ runs-on: ubuntu-latest
+ container:
+ image: amd64/rust
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup Rust toolchain
+ uses: ./.github/actions/setup-builder
+ - name: Run gen
+ run: ./regen.sh
+ working-directory: ./datafusion/proto
Review Comment:
This part shouldn't be necessary, as the script already handles this, but I suppose it can't hurt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] l0kr commented on pull request #5742: Move protoc generation to binary crate (#5718)
Posted by "l0kr (via GitHub)" <gi...@apache.org>.
l0kr commented on PR #5742:
URL: https://github.com/apache/arrow-datafusion/pull/5742#issuecomment-1484112811
> Could we get a CI check, similar to https://github.com/apache/arrow-rs/pull/3927/files#diff-7a5f24a0bed6232c2297eba93812cdaeb26327ba955eabc0a04effc21e95d52bR65
Should I create another yaml or add check to existing one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #5742: Move protoc generation to binary crate (#5718)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #5742:
URL: https://github.com/apache/arrow-datafusion/pull/5742#issuecomment-1484113035
I think adding it to https://github.com/apache/arrow-datafusion/blob/main/.github/workflows/rust.yml would make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5742: Move protoc generation to binary crate (#5718)
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5742:
URL: https://github.com/apache/arrow-datafusion/pull/5742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #5742: Move protoc generation to binary crate (#5718)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #5742:
URL: https://github.com/apache/arrow-datafusion/pull/5742#discussion_r1148560840
##########
datafusion/proto/gen/Cargo.toml:
##########
@@ -0,0 +1,34 @@
+# or more contributor license agreements. See the NOTICE file
Review Comment:
This license header appears to be truncated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on pull request #5742: Move protoc generation to binary crate (#5718)
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #5742:
URL: https://github.com/apache/arrow-datafusion/pull/5742#issuecomment-1484102476
Could we get a CI check, similar to https://github.com/apache/arrow-rs/pull/3927/files#diff-7a5f24a0bed6232c2297eba93812cdaeb26327ba955eabc0a04effc21e95d52bR65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org