You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@shiro.apache.org by ted <ft...@gmail.com> on 2012/02/28 06:26:34 UTC
private boolean isPermitted(Permission permission,
AuthorizationInfo info) as public?
Hey guys,
What was the motivation behind the decision of making the following method
private?
AuthorizingRealm, line 465:
private boolean isPermitted(Permission permission, AuthorizationInfo info)
As for me, it's a pretty convenient extension point, since all the other
isPermitted* and isPermittedAll* methods are using this method, so maybe it
would be better to make it protected instead of private?
--
View this message in context: http://shiro-user.582556.n2.nabble.com/private-boolean-isPermitted-Permission-permission-AuthorizationInfo-info-as-public-tp7324533p7324533.html
Sent from the Shiro User mailing list archive at Nabble.com.
Re: private boolean isPermitted(Permission permission,
AuthorizationInfo info) as public?
Posted by Jared Bunting <ja...@peachjean.com>.
I'm curious about what you would want to use this method for. Care to
share?
Thanks,
Jared
On Feb 28, 2012 12:01 PM, "Les Hazlewood" <lh...@apache.org> wrote:
> No reason in particular other than to minimize the number of public
> extension points. The more of them there are, the more maintenance is
> required for the dev team for backwards compatibility.
>
> If you feel this should be enabled, please feel free to open a Jira issue.
>
> Cheers,
>
> Les
>
> On Mon, Feb 27, 2012 at 9:26 PM, ted <ft...@gmail.com> wrote:
> > Hey guys,
> >
> > What was the motivation behind the decision of making the following
> method
> > private?
> > AuthorizingRealm, line 465:
> > private boolean isPermitted(Permission permission, AuthorizationInfo
> info)
> >
> > As for me, it's a pretty convenient extension point, since all the other
> > isPermitted* and isPermittedAll* methods are using this method, so maybe
> it
> > would be better to make it protected instead of private?
> >
> > --
> > View this message in context:
> http://shiro-user.582556.n2.nabble.com/private-boolean-isPermitted-Permission-permission-AuthorizationInfo-info-as-public-tp7324533p7324533.html
> > Sent from the Shiro User mailing list archive at Nabble.com.
>
Re: private boolean isPermitted(Permission permission,
AuthorizationInfo info) as public?
Posted by Les Hazlewood <lh...@apache.org>.
No reason in particular other than to minimize the number of public
extension points. The more of them there are, the more maintenance is
required for the dev team for backwards compatibility.
If you feel this should be enabled, please feel free to open a Jira issue.
Cheers,
Les
On Mon, Feb 27, 2012 at 9:26 PM, ted <ft...@gmail.com> wrote:
> Hey guys,
>
> What was the motivation behind the decision of making the following method
> private?
> AuthorizingRealm, line 465:
> private boolean isPermitted(Permission permission, AuthorizationInfo info)
>
> As for me, it's a pretty convenient extension point, since all the other
> isPermitted* and isPermittedAll* methods are using this method, so maybe it
> would be better to make it protected instead of private?
>
> --
> View this message in context: http://shiro-user.582556.n2.nabble.com/private-boolean-isPermitted-Permission-permission-AuthorizationInfo-info-as-public-tp7324533p7324533.html
> Sent from the Shiro User mailing list archive at Nabble.com.