[GitHub] [maven-wrapper] hazendaz commented on pull request #44: [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script

[GitBox <gi...@apache.org>]

hazendaz commented on PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#issuecomment-1129200037

   The script file can be either windows or Unix based as that doesn't seem to cause issue.  Possibly it's from the read of wrapper properties.  Tried printing the data there but all looked ok.  Adding this did fix it.
   
   Sent from my Verizon, Samsung Galaxy smartphone
   Get Outlook for Android<https://aka.ms/AAb9ysg>
   ________________________________
   From: Michael Osipov ***@***.***>
   Sent: Tuesday, May 17, 2022 2:33:27 PM
   To: apache/maven-wrapper ***@***.***>
   Cc: Jeremy Landis ***@***.***>; Author ***@***.***>
   Subject: Re: [apache/maven-wrapper] [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script (PR #44)
   
   
   @michael-o commented on this pull request.
   
   ________________________________
   
   In maven-wrapper-distribution/src/resources/mvnw<https://github.com/apache/maven-wrapper/pull/44#discussion_r875146529>:
   
   > @@ -198,6 +198,8 @@ else
        if [ "$MVNW_VERBOSE" = true ]; then
          echo "Downloading from: $wrapperUrl"
        fi
   +    # Remove invalid line endings from wrapperUrl
   +    wrapperUrl=${wrapperUrl%$'\r'}
   
   
   Where does the URL come from? Do we need to fix the line ending of this resource in Git?
   
   —
   Reply to this email directly, view it on GitHub<https://github.com/apache/maven-wrapper/pull/44#pullrequestreview-975930586>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI3AEZNI7SN3VKRO57DVKPQ7PANCNFSM5WFVGSHQ>.
   You are receiving this because you authored the thread.Message ID: ***@***.***>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org