You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/14 06:13:10 UTC
[GitHub] [doris] Kikyou1997 opened a new pull request, #10839: [feature](nereids) Integrate existing stats framework to nereids
Kikyou1997 opened a new pull request, #10839:
URL: https://github.com/apache/doris/pull/10839
# Proposed changes
Issue Number: noissue
## Problem Summary:
## Checklist(Required)
1. Does it affect the original behavior: No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #10839: [feature](nereids) Integrate existing stats framework to nereids
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on code in PR #10839:
URL: https://github.com/apache/doris/pull/10839#discussion_r920934088
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/StatsCalculator.java:
##########
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalAggregate;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalDistribution;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalFilter;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHeapSort;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.plans.visitor.DefaultPlanVisitor;
+import org.apache.doris.statistics.AggStatsDerive;
+import org.apache.doris.statistics.ExchangeStatsDerive;
+import org.apache.doris.statistics.FilterStatsDerive;
+import org.apache.doris.statistics.HashJoinStatsDerive;
+import org.apache.doris.statistics.OlapScanStatsDerive;
+import org.apache.doris.statistics.SelectStatsDerive;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+/**
+ * This class is used to get the statistics info for each group.
+ */
+public class StatsCalculator extends DefaultPlanVisitor<StatsDeriveResult, PlanContext> {
+
+ /**
+ * Gather statistic information of GroupExpression's parent group.
+ */
+ public void estimate(GroupExpression groupExpression) {
+ Plan plan = groupExpression.getPlan();
+ PlanContext planContext = new PlanContext(groupExpression);
+ StatsDeriveResult stats = plan.accept(this, planContext);
+ groupExpression.getParent().setStatistics(planContext.getStatistics());
+ plan.setStatsDeriveResult(stats);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 commented on a diff in pull request #10839: [feature](nereids) Integrate existing stats framework to nereids
Posted by GitBox <gi...@apache.org>.
Kikyou1997 commented on code in PR #10839:
URL: https://github.com/apache/doris/pull/10839#discussion_r920826073
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/StatsCalculator.java:
##########
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalAggregate;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalDistribution;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalFilter;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHeapSort;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.plans.visitor.DefaultPlanVisitor;
+import org.apache.doris.statistics.AggStatsDerive;
+import org.apache.doris.statistics.ExchangeStatsDerive;
+import org.apache.doris.statistics.FilterStatsDerive;
+import org.apache.doris.statistics.HashJoinStatsDerive;
+import org.apache.doris.statistics.OlapScanStatsDerive;
+import org.apache.doris.statistics.SelectStatsDerive;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+/**
+ * This class is used to get the statistics info for each group.
+ */
+public class StatsCalculator extends DefaultPlanVisitor<StatsDeriveResult, PlanContext> {
+
+ /**
+ * Gather statistic information of GroupExpression's parent group.
+ */
+ public void estimate(GroupExpression groupExpression) {
+ Plan plan = groupExpression.getPlan();
Review Comment:
I think there is no need to recursively visit child plan, DeriveStatsJob will handle this recursively with a stack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #10839: [feature](nereids) Integrate existing stats framework to nereids
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #10839:
URL: https://github.com/apache/doris/pull/10839#discussion_r920794187
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/StatsCalculator.java:
##########
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalAggregate;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalDistribution;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalFilter;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHeapSort;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.plans.visitor.DefaultPlanVisitor;
+import org.apache.doris.statistics.AggStatsDerive;
+import org.apache.doris.statistics.ExchangeStatsDerive;
+import org.apache.doris.statistics.FilterStatsDerive;
+import org.apache.doris.statistics.HashJoinStatsDerive;
+import org.apache.doris.statistics.OlapScanStatsDerive;
+import org.apache.doris.statistics.SelectStatsDerive;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+/**
+ * This class is used to get the statistics info for each group.
+ */
+public class StatsCalculator extends DefaultPlanVisitor<StatsDeriveResult, PlanContext> {
+
+ /**
+ * Gather statistic information of GroupExpression's parent group.
+ */
+ public void estimate(GroupExpression groupExpression) {
+ Plan plan = groupExpression.getPlan();
Review Comment:
groupExpression.getPlan() will return a plan with GroupPlan as children, so DefaultPlanVisitor will stop recursive visit plan when visit GroupPlan.
so you must rewrite visitGroupPlan to recursive visit children plans, maybe in the PlanVisitor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #10839: [feature](nereids) Integrate existing stats framework to nereids
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #10839:
URL: https://github.com/apache/doris/pull/10839#discussion_r920794187
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/StatsCalculator.java:
##########
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalAggregate;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalDistribution;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalFilter;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHeapSort;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.plans.visitor.DefaultPlanVisitor;
+import org.apache.doris.statistics.AggStatsDerive;
+import org.apache.doris.statistics.ExchangeStatsDerive;
+import org.apache.doris.statistics.FilterStatsDerive;
+import org.apache.doris.statistics.HashJoinStatsDerive;
+import org.apache.doris.statistics.OlapScanStatsDerive;
+import org.apache.doris.statistics.SelectStatsDerive;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+/**
+ * This class is used to get the statistics info for each group.
+ */
+public class StatsCalculator extends DefaultPlanVisitor<StatsDeriveResult, PlanContext> {
+
+ /**
+ * Gather statistic information of GroupExpression's parent group.
+ */
+ public void estimate(GroupExpression groupExpression) {
+ Plan plan = groupExpression.getPlan();
Review Comment:
groupExpression.getPlan() will return a plan with GroupPlan as children, so DefaultPlanVisitor will stop recursive visit plan when visit GroupPlan.
so you must rewrite visitGroupPlan to recursive visit children plans
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Kikyou1997 closed pull request #10839: [feature](nereids) Integrate existing stats framework to nereids
Posted by GitBox <gi...@apache.org>.
Kikyou1997 closed pull request #10839: [feature](nereids) Integrate existing stats framework to nereids
URL: https://github.com/apache/doris/pull/10839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #10839: [feature](nereids) Integrate existing stats framework to nereids
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #10839:
URL: https://github.com/apache/doris/pull/10839#discussion_r920794187
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/StatsCalculator.java:
##########
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalAggregate;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalDistribution;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalFilter;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHeapSort;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.plans.visitor.DefaultPlanVisitor;
+import org.apache.doris.statistics.AggStatsDerive;
+import org.apache.doris.statistics.ExchangeStatsDerive;
+import org.apache.doris.statistics.FilterStatsDerive;
+import org.apache.doris.statistics.HashJoinStatsDerive;
+import org.apache.doris.statistics.OlapScanStatsDerive;
+import org.apache.doris.statistics.SelectStatsDerive;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+/**
+ * This class is used to get the statistics info for each group.
+ */
+public class StatsCalculator extends DefaultPlanVisitor<StatsDeriveResult, PlanContext> {
+
+ /**
+ * Gather statistic information of GroupExpression's parent group.
+ */
+ public void estimate(GroupExpression groupExpression) {
+ Plan plan = groupExpression.getPlan();
Review Comment:
groupExpression.getPlan() will return a plan with GroupPlan as children, so DefaultPlanVisitor will stop recursive visit plan when visit GroupPlan.
so you must rewrite visitGroupPlan to recursive visit children plans
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #10839: [feature](nereids) Integrate existing stats framework to nereids
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #10839:
URL: https://github.com/apache/doris/pull/10839#discussion_r920843804
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/StatsCalculator.java:
##########
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalAggregate;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalDistribution;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalFilter;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHeapSort;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.plans.visitor.DefaultPlanVisitor;
+import org.apache.doris.statistics.AggStatsDerive;
+import org.apache.doris.statistics.ExchangeStatsDerive;
+import org.apache.doris.statistics.FilterStatsDerive;
+import org.apache.doris.statistics.HashJoinStatsDerive;
+import org.apache.doris.statistics.OlapScanStatsDerive;
+import org.apache.doris.statistics.SelectStatsDerive;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+/**
+ * This class is used to get the statistics info for each group.
+ */
+public class StatsCalculator extends DefaultPlanVisitor<StatsDeriveResult, PlanContext> {
+
+ /**
+ * Gather statistic information of GroupExpression's parent group.
+ */
+ public void estimate(GroupExpression groupExpression) {
+ Plan plan = groupExpression.getPlan();
+ PlanContext planContext = new PlanContext(groupExpression);
+ StatsDeriveResult stats = plan.accept(this, planContext);
+ groupExpression.getParent().setStatistics(planContext.getStatistics());
+ plan.setStatsDeriveResult(stats);
Review Comment:
plan is immutable structure, maybe we should store mutable information in the GroupExpression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 924060929 commented on a diff in pull request #10839: [feature](nereids) Integrate existing stats framework to nereids
Posted by GitBox <gi...@apache.org>.
924060929 commented on code in PR #10839:
URL: https://github.com/apache/doris/pull/10839#discussion_r920794187
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/StatsCalculator.java:
##########
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.cost;
+
+import org.apache.doris.nereids.PlanContext;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.trees.plans.Plan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalAggregate;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalDistribution;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalFilter;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHashJoin;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalHeapSort;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalOlapScan;
+import org.apache.doris.nereids.trees.plans.physical.PhysicalProject;
+import org.apache.doris.nereids.trees.plans.visitor.DefaultPlanVisitor;
+import org.apache.doris.statistics.AggStatsDerive;
+import org.apache.doris.statistics.ExchangeStatsDerive;
+import org.apache.doris.statistics.FilterStatsDerive;
+import org.apache.doris.statistics.HashJoinStatsDerive;
+import org.apache.doris.statistics.OlapScanStatsDerive;
+import org.apache.doris.statistics.SelectStatsDerive;
+import org.apache.doris.statistics.StatsDeriveResult;
+
+/**
+ * This class is used to get the statistics info for each group.
+ */
+public class StatsCalculator extends DefaultPlanVisitor<StatsDeriveResult, PlanContext> {
+
+ /**
+ * Gather statistic information of GroupExpression's parent group.
+ */
+ public void estimate(GroupExpression groupExpression) {
+ Plan plan = groupExpression.getPlan();
Review Comment:
groupExpression.getPlan() will return a plan with GroupPlan as children, so DefaultPlanVisitor will stop recursive visit plan when visit GroupPlan.
so you must rewrite visitGroupPlan to recursive visit children plans?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #10839: [feature](nereids) Integrate existing stats framework to nereids
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #10839:
URL: https://github.com/apache/doris/pull/10839#discussion_r921136455
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/PlanContext.java:
##########
@@ -103,4 +109,34 @@ public StatsDeriveResult getChildStatistics(int index) {
Preconditions.checkNotNull(statistics);
return statistics;
}
+
+ @Override
+ public StatsDeriveResult getStatsDeriveResult() {
+ if (groupExpression != null) {
+ return groupExpression.getParent().getStatistics();
+ }
+ return plan.getStats();
+ }
+
+ @Override
+ public void setStatsDeriveResult(StatsDeriveResult result) {
+ if (groupExpression != null) {
+ groupExpression.getParent().setStatistics(result);
+ groupExpression.setStatDerived(true);
+ }
+ plan.setStats(result);
Review Comment:
```suggestion
} else {
plan.setStats(result);
}
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/PlanContext.java:
##########
@@ -36,7 +42,7 @@
* A ExpressionHandle is attached to either {@link Plan} or {@link GroupExpression}.
* Inspired by GPORCA-CExpressionHandle.
*/
-public class PlanContext {
+public class PlanContext implements PlanStats {
Review Comment:
maybe we need remove PlanContext and let GroupExpression implements PlanStats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org