You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/01 13:18:31 UTC

[GitHub] [spark] beliefer commented on a change in pull request #34738: [SPARK-37483][SQL] Support push down top N to JDBC data source V2

beliefer commented on a change in pull request #34738:
URL: https://github.com/apache/spark/pull/34738#discussion_r760174691



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -370,6 +370,8 @@ abstract class JdbcDialect extends Serializable with Logging{
    */
   def supportsLimit(): Boolean = true
 
+  def supportsTopN(): Boolean = true

Review comment:
       I guess not exists the one.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org