You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ha...@apache.org on 2017/06/28 16:27:00 UTC

git commit: [flex-asjs] [refs/heads/tlf] - Just a comment

Repository: flex-asjs
Updated Branches:
  refs/heads/tlf c6e721f93 -> c89b3a11e


Just a comment


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/c89b3a11
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/c89b3a11
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/c89b3a11

Branch: refs/heads/tlf
Commit: c89b3a11e3b137523568a7db806c6bbc2fe6f34d
Parents: c6e721f
Author: Harbs <ha...@in-tools.com>
Authored: Wed Jun 28 19:26:56 2017 +0300
Committer: Harbs <ha...@in-tools.com>
Committed: Wed Jun 28 19:26:56 2017 +0300

----------------------------------------------------------------------
 .../main/flex/org/apache/flex/textLayout/compose/BaseCompose.as    | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c89b3a11/frameworks/projects/TLF/src/main/flex/org/apache/flex/textLayout/compose/BaseCompose.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/TLF/src/main/flex/org/apache/flex/textLayout/compose/BaseCompose.as b/frameworks/projects/TLF/src/main/flex/org/apache/flex/textLayout/compose/BaseCompose.as
index 75fb687..c20acfa 100644
--- a/frameworks/projects/TLF/src/main/flex/org/apache/flex/textLayout/compose/BaseCompose.as
+++ b/frameworks/projects/TLF/src/main/flex/org/apache/flex/textLayout/compose/BaseCompose.as
@@ -2168,6 +2168,8 @@ package org.apache.flex.textLayout.compose
 						// Now it is implicitly deduced based on the container-level locale in the following manner: 
 						// IDEOGRAPHIC_BOTTOM for ja and zh locales (this is the same locale set for which the default LeadingModel is IDEOGRAPHIC_TOP_DOWN)
 						// ROMAN for all other locales
+						// ITextLine.getBaselinePosition() returns the relative position to the composed baseline.
+						// If both were roman, it will return 0.
 						var firstBaselineOffsetBasis:String = LocaleUtil.leadingModel(containerAttrs.locale) == LeadingModel.IDEOGRAPHIC_TOP_DOWN ?  TextBaseline.IDEOGRAPHIC_BOTTOM : TextBaseline.ROMAN;
 						lineHeight -= curTextLine.getBaselinePosition(firstBaselineOffsetBasis);		
 					}