You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/29 16:18:24 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request, #6841: default should map always, not require the minHypervisorVersion
DaanHoogland opened a new pull request, #6841:
URL: https://github.com/apache/cloudstack/pull/6841
### Description
This PR fixes an logic error in #6758
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1367517504
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6841](https://codecov.io/gh/apache/cloudstack/pull/6841?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a48cef) into [main](https://codecov.io/gh/apache/cloudstack/commit/4a0636374931e4e6b562def76acb9f8673a7f22a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a06363) will **increase** coverage by `0.47%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #6841 +/- ##
============================================
+ Coverage 10.84% 11.31% +0.47%
- Complexity 7095 7332 +237
============================================
Files 2485 2494 +9
Lines 245370 246787 +1417
Branches 38319 38533 +214
============================================
+ Hits 26602 27929 +1327
+ Misses 215500 215260 -240
- Partials 3268 3598 +330
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...om/cloud/storage/dao/GuestOSHypervisorDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zdG9yYWdlL2Rhby9HdWVzdE9TSHlwZXJ2aXNvckRhb0ltcGwuamF2YQ==) | `32.25% <0.00%> (ø)` | |
| [...va/com/cloud/upgrade/dao/DatabaseAccessObject.java](https://codecov.io/gh/apache/cloudstack/pull/6841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9EYXRhYmFzZUFjY2Vzc09iamVjdC5qYXZh) | `0.00% <0.00%> (-97.50%)` | :arrow_down: |
| [...ain/java/com/cloud/upgrade/dao/DbUpgradeUtils.java](https://codecov.io/gh/apache/cloudstack/pull/6841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9EYlVwZ3JhZGVVdGlscy5qYXZh) | `0.00% <0.00%> (-92.31%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/Upgrade444to450.java](https://codecov.io/gh/apache/cloudstack/pull/6841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDQ0dG80NTAuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/Upgrade453to460.java](https://codecov.io/gh/apache/cloudstack/pull/6841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDUzdG80NjAuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...java/com/cloud/upgrade/DatabaseUpgradeChecker.java](https://codecov.io/gh/apache/cloudstack/pull/6841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL0RhdGFiYXNlVXBncmFkZUNoZWNrZXIuamF2YQ==) | `0.00% <0.00%> (-46.67%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/Upgrade431to440.java](https://codecov.io/gh/apache/cloudstack/pull/6841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDMxdG80NDAuamF2YQ==) | `0.00% <0.00%> (-40.00%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/Upgrade432to440.java](https://codecov.io/gh/apache/cloudstack/pull/6841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDMydG80NDAuamF2YQ==) | `0.00% <0.00%> (-40.00%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/LegacyDbUpgrade.java](https://codecov.io/gh/apache/cloudstack/pull/6841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9MZWdhY3lEYlVwZ3JhZGUuamF2YQ==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
| [.../com/cloud/storage/dao/StoragePoolTagsDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6841/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zdG9yYWdlL2Rhby9TdG9yYWdlUG9vbFRhZ3NEYW9JbXBsLmphdmE=) | `12.90% <0.00%> (-32.26%)` | :arrow_down: |
| ... and [174 more](https://codecov.io/gh/apache/cloudstack/pull/6841/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1335567465
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1683557014
> @weizhouapache I think this is a solution looking for a problem. Shall I close?
@DaanHoogland
The old logic seems wrong but fixed #6736 (the return results are always not empty)
the new logic looks good, but #6736 may come back again (the return results might be null).
I have no idea how to proceed ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1683664268
> > @weizhouapache I think this is a solution looking for a problem. Shall I close?
>
> @DaanHoogland The old logic seems wrong but fixed #6736 (the return results are always not empty) the new logic looks good, but #6736 may come back again (the return results might be null). I have no idea how to proceed ..
ok, closing. we can always re-open
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1367442097
> @DaanHoogland this is closed ?
yes it was, forgot to reopen to restart actions...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1545339610
added to 4.18.1.0 milestone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1682346938
manual test is required to test if https://github.com/apache/cloudstack/issues/6736 is fixed or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1340345489
<b>Trillian test result (tid-5407)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42907 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6841-t5407-vmware-67u3.zip
Smoke tests completed. 95 look OK, 2 have errors, 8 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_3d_gpu_support | `Error` | 594.47 | test_deploy_vgpu_enabled_vm.py
test_deploy_vgpu_enabled_vm | `Error` | 3.02 | test_deploy_vgpu_enabled_vm.py
test_13_migrate_volume_and_change_offering | `Error` | 15.57 | test_volumes.py
ContextSuite context=TestVolumes>:teardown | `Error` | 22.30 | test_volumes.py
all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
all_test_templates | `Skipped` | --- | test_templates.py
all_test_create_list_domain_account_project | `Skipped` | --- | test_create_list_domain_account_project.py
all_test_primary_storage | `Skipped` | --- | test_primary_storage.py
all_test_create_network | `Skipped` | --- | test_create_network.py
all_test_network_acl | `Skipped` | --- | test_network_acl.py
all_test_network_ipv6 | `Skipped` | --- | test_network_ipv6.py
all_test_deploy_vm_extra_config_data | `Skipped` | --- | test_deploy_vm_extra_config_data.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1367476975
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6841)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6841&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6841&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6841&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1669626337
ping @weizhouapache
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #6841: default should map always, not require the minHypervisorVersion
URL: https://github.com/apache/cloudstack/pull/6841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1335453071
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1343933942
<b>Trillian test result (tid-5434)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52438 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6841-t5434-vmware-67u3.zip
Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_upgrade_kubernetes_cluster | `Error` | 4005.55 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 583.69 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 381.46 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1339586357
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6841: default should map always, not should match the minHypervirorVersion
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1286953774
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1396619394
> From what I can see, this haven't been fixed yet, here is what I got when testing as described in issue #6736:
>
> When registering the mentioned template (PI-VA-3.10.0.0.205.ova) with 'Read from OVA', here is the result: Did not find a guest OS (Red Hat Enterprise Linux 7 (64-bit)) with type "rhel7_64Guest" and minimal hypervisor hardware version null.
>
> 
>
> when 'Read from OVA' is false, the same template is properly registered.
i think we have to check if this is a scenario that would work before this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1682359283
@DaanHoogland
I doubt if it works.
it looks `default` have much few guest os mappings then `7.0`. If we search guest os mapping by hypervisor version `default`, it may return empty results, which leads to #6736 to appear again.
```
mysql> select count(1) from guest_os_hypervisor where hypervisor_type ='VMware' and hypervisor_version ='default';
+----------+
| count(1) |
+----------+
| 118 |
+----------+
1 row in set (0.00 sec)
mysql>
mysql>
mysql> select count(1) from guest_os_hypervisor where hypervisor_type ='VMware' and hypervisor_version ='7.0';
+----------+
| count(1) |
+----------+
| 258 |
+----------+
1 row in set (0.00 sec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1339064408
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not should match the minHypervirorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1287007554
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 4520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1669630863
@rohityadavcloud a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed pull request #6841: default should map always, not require the minHypervisorVersion
URL: https://github.com/apache/cloudstack/pull/6841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1609137460
Not sure if manual testing is needed, but other LGTM. Thanks @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6841: default should map always, not should match the minHypervirorVersion
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1287018882
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6841)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6841&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6841&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6841&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not should match the minHypervirorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1287594244
<b>Trillian test result (tid-5187)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43602 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6841-t5187-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 462.06 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1301800096
@borisstoyanov I think we need this in for the upload of OVAs not having a hypervisor version and preventing those that have a too high hypervisor version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1387416494
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6841)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6841&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6841&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6841&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6841&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6841&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1683536211
@weizhouapache I think this is a solution looking for a problem. Shall I close?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1669763553
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 6707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6841: default should map always, not should match the minHypervirorVersion
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1287041004
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1346188835
> code lgtm, but I wonder ##6736 will be back again
I don´t think so. @borisstoyanov can you look at that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#discussion_r1188780567
##########
engine/schema/src/main/java/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java:
##########
@@ -157,7 +157,7 @@ public List<GuestOSHypervisorVO> listByOsNameAndHypervisorMinimumVersion(String
sc.and(sc.entity().getGuestOsName(), SearchCriteria.Op.EQ, guestOsName);
sc.and(sc.entity().getHypervisorType(), SearchCriteria.Op.EQ, hypervisorType);
sc.and().op(sc.entity().getHypervisorVersion(), SearchCriteria.Op.GTEQ, minHypervisorVersion);
- sc.or(sc.entity().getHypervisorVersion(), SearchCriteria.Op.NEQ, "default");
+ sc.or(sc.entity().getHypervisorVersion(), SearchCriteria.Op.EQ, "default");
Review Comment:
no, default is not part of the simver and it is OR'ed so I think EQ is good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6841: default should map always, not require the minHypervisorVersion
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on code in PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#discussion_r1187113496
##########
engine/schema/src/main/java/com/cloud/storage/dao/GuestOSHypervisorDaoImpl.java:
##########
@@ -157,7 +157,7 @@ public List<GuestOSHypervisorVO> listByOsNameAndHypervisorMinimumVersion(String
sc.and(sc.entity().getGuestOsName(), SearchCriteria.Op.EQ, guestOsName);
sc.and(sc.entity().getHypervisorType(), SearchCriteria.Op.EQ, hypervisorType);
sc.and().op(sc.entity().getHypervisorVersion(), SearchCriteria.Op.GTEQ, minHypervisorVersion);
- sc.or(sc.entity().getHypervisorVersion(), SearchCriteria.Op.NEQ, "default");
+ sc.or(sc.entity().getHypervisorVersion(), SearchCriteria.Op.EQ, "default");
Review Comment:
should this be GTEQ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #6841: default should map always, not require the minHypervisorVersion
URL: https://github.com/apache/cloudstack/pull/6841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1367381639
@DaanHoogland
this is closed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not should match the minHypervirorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1289454755
<b>Trillian test result (tid-5190)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41170 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6841-t5190-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 458.19 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not should match the minHypervirorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1287042211
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not should match the minHypervirorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1286955159
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1335254024
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1387276577
From what I can see, this haven't been fixed yet, here is what I got when testing as described in issue #6736:
When registering the mentioned template (PI-VA-3.10.0.0.205.ova) with 'Read from OVA', here is the result:
Did not find a guest OS (Red Hat Enterprise Linux 7 (64-bit)) with type "rhel7_64Guest" and minimal hypervisor hardware version null.
when 'Read from OVA' is false, the same template is properly registered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1339585370
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6841: default should map always, not require the minHypervisorVersion
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6841:
URL: https://github.com/apache/cloudstack/pull/6841#issuecomment-1343943424
code lgtm, but I wonder ##6736 will be back again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org