You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Aldrin Montana (Jira)" <ji...@apache.org> on 2022/09/07 16:52:00 UTC
[jira] [Commented] (ARROW-16424) [C++] Update uri_path parsing in FromProto
[ https://issues.apache.org/jira/browse/ARROW-16424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601403#comment-17601403 ]
Aldrin Montana commented on ARROW-16424:
----------------------------------------
I wanted to note some of the unit tests that were disabled due to ARROW-16392, which can be re-enabled when this is addressed:
* [DeserializeWithConsumerFactory|https://github.com/apache/arrow/blob/master/cpp/src/arrow/engine/substrait/serde_test.cc#L901-L922]
* [DeserializeSinglePlanWithConsumerFactory|https://github.com/apache/arrow/blob/master/cpp/src/arrow/engine/substrait/serde_test.cc#L924-L942]
* [DeserializeWithWriteOptionsFactory|https://github.com/apache/arrow/blob/master/cpp/src/arrow/engine/substrait/serde_test.cc#L944-L985]
* [GetRecordBatchReader|https://github.com/apache/arrow/blob/master/cpp/src/arrow/engine/substrait/serde_test.cc#L998-L1013]
(as of commit [ff3aa3b|https://github.com/apache/arrow/blob/ff3aa3b7bb31c679892d19ff74d67563b986828f/cpp/src/arrow/engine/substrait/serde_test.cc])
> [C++] Update uri_path parsing in FromProto
> ------------------------------------------
>
> Key: ARROW-16424
> URL: https://issues.apache.org/jira/browse/ARROW-16424
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Ariana Villegas
> Assignee: Sanjiban Sengupta
> Priority: Minor
> Labels: pull-request-available, substrait
> Time Spent: 2h
> Remaining Estimate: 0h
>
> FromProto function in {{arrow/engine/substrait/relation_internal.cc}} parse {{uri_path}} with {{string_view}} utilities. However this should be done with {{Uri}} class from {{arrow/util/uri.h.}}
> {code:c++}
> else if (util::string_view{path}.ends_with(".arrow")) {
> format = std::make_shared<dataset::IpcFileFormat>();
> } else if (util::string_view{path}.ends_with(".feather")) {
> format = std::make_shared<dataset::IpcFileFormat>();
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)