[GitHub] [activemq-artemis] fvaleri commented on issue #3043: NO-JIRA: OpenWireMessageConverter refactoring

[GitBox <gi...@apache.org>]

fvaleri commented on issue #3043: NO-JIRA: OpenWireMessageConverter refactoring
URL: https://github.com/apache/activemq-artemis/pull/3043#issuecomment-604290495
 
 
   @michaelpearce-gain there was a small error in a class rename, now fixed.
   
   I completely understand that stability matter the most and it may take some time to be verified by another developer. I'm also open to discussion here. 
   
   The whole point of refactoring is to alter the internal structure without changing its external behavior, so there shouldn't be new features or fixes. The reward in this case should be better maintainability, at least this is the intention.
   
   Specifically, this is copying the AMQP protocol module layout, which splits the inbound and outbound converters in dedicated classes (they were already distinct but hosted on the same big class). In my opinion this is much more clean.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services