You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Alexei Fedotov <al...@gmail.com> on 2008/03/27 16:05:51 UTC
Changing default federated build target Was: [jira] Commented: (HARMONY-5521) [build] fix incremental federated build
Tim wrote in HARMONY-5521:
> Why not make the incremental build the default? This is more likely the one people will be using daily.
We should ask people who are in charge of snapshot creation since they
probably use a default target for their script now. It might be good
to rename the "default" target into "all" or something because it
would not be conventional to call it "default" any longer. This is
done via incremental_build_1.patch [2]. Stepan, Alexey, what do you
about Tim's suggestion and the patch?
The following step would be to do something about class library
natives which are rebuilt each time.
[1] https://issues.apache.org/jira/browse/HARMONY-5521
[2] https://issues.apache.org/jira/secure/attachment/12378724/incremental_build_1.patch
On Thu, Mar 27, 2008 at 5:29 PM, Tim Ellison (JIRA) <ji...@apache.org> wrote:
>
>
> [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582662#action_12582662 ]
>
> Tim Ellison commented on HARMONY-5521:
> --------------------------------------
>
> Why not make the incremental build the default? This is more likely the one people will be using daily.
>
>
> > [build] fix incremental federated build
> > ---------------------------------------
> >
> > Key: HARMONY-5521
> > URL: https://issues.apache.org/jira/browse/HARMONY-5521
> > Project: Harmony
> > Issue Type: Improvement
> > Components: build - test - ci
> > Reporter: Alexei Fedotov
> > Assignee: Pavel Pervov
> > Attachments: incremental_build.patch
> >
> >
> > This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
--
With best regards,
Alexei
Re: Changing default federated build target Was: [jira] Commented:
(HARMONY-5521) [build] fix incremental federated build
Posted by Tim Ellison <t....@gmail.com>.
Alexei Fedotov wrote:
> Tim, I renamed "build-all" to "build" to follow this pattern. It was
> Geir who addded "clean" target long time ago. Do you want "rebuild"
> target to be added?
That would suit me (the target names I have become used to using) and
would be consistent. Thanks.
Tim
> On Thu, Mar 27, 2008 at 6:11 PM, Tim Ellison <t....@gmail.com> wrote:
>> FWIW the names used in the classlib level build script are:
>>
>> build - default target, does an incremental build
>> clean - as you would expect
>> rebuild - clean followed by build
>> ...
>>
>> Maybe it would be good to be consistent with the names here.
>>
>> Regards,
>> Tim
>>
>>
>>
>>
>> Alexei Fedotov wrote:
>> > Tim wrote in HARMONY-5521:
>> >> Why not make the incremental build the default? This is more likely the one people will be using daily.
>> >
>> > We should ask people who are in charge of snapshot creation since they
>> > probably use a default target for their script now. It might be good
>> > to rename the "default" target into "all" or something because it
>> > would not be conventional to call it "default" any longer. This is
>> > done via incremental_build_1.patch [2]. Stepan, Alexey, what do you
>> > about Tim's suggestion and the patch?
>> >
>> > The following step would be to do something about class library
>> > natives which are rebuilt each time.
>> >
>> > [1] https://issues.apache.org/jira/browse/HARMONY-5521
>> > [2] https://issues.apache.org/jira/secure/attachment/12378724/incremental_build_1.patch
>> >
>> > On Thu, Mar 27, 2008 at 5:29 PM, Tim Ellison (JIRA) <ji...@apache.org> wrote:
>> >>
>> >> [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582662#action_12582662 ]
>> >>
>> >> Tim Ellison commented on HARMONY-5521:
>> >> --------------------------------------
>> >>
>> >> Why not make the incremental build the default? This is more likely the one people will be using daily.
>> >>
>> >>
>> >> > [build] fix incremental federated build
>> >> > ---------------------------------------
>> >> >
>> >> > Key: HARMONY-5521
>> >> > URL: https://issues.apache.org/jira/browse/HARMONY-5521
>> >> > Project: Harmony
>> >> > Issue Type: Improvement
>> >> > Components: build - test - ci
>> >> > Reporter: Alexei Fedotov
>> >> > Assignee: Pavel Pervov
>> >> > Attachments: incremental_build.patch
>> >> >
>> >> >
>> >> > This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.
>> >>
>> >> --
>> >> This message is automatically generated by JIRA.
>> >> -
>> >> You can reply to this email to add a comment to the issue online.
>> >>
>> >>
>> >
>> >
>> >
>>
>
>
>
Re: Changing default federated build target Was: [jira] Commented: (HARMONY-5521) [build] fix incremental federated build
Posted by Alexei Fedotov <al...@gmail.com>.
Tim, I renamed "build-all" to "build" to follow this pattern. It was
Geir who addded "clean" target long time ago. Do you want "rebuild"
target to be added?
On Thu, Mar 27, 2008 at 6:11 PM, Tim Ellison <t....@gmail.com> wrote:
> FWIW the names used in the classlib level build script are:
>
> build - default target, does an incremental build
> clean - as you would expect
> rebuild - clean followed by build
> ...
>
> Maybe it would be good to be consistent with the names here.
>
> Regards,
> Tim
>
>
>
>
> Alexei Fedotov wrote:
> > Tim wrote in HARMONY-5521:
> >> Why not make the incremental build the default? This is more likely the one people will be using daily.
> >
> > We should ask people who are in charge of snapshot creation since they
> > probably use a default target for their script now. It might be good
> > to rename the "default" target into "all" or something because it
> > would not be conventional to call it "default" any longer. This is
> > done via incremental_build_1.patch [2]. Stepan, Alexey, what do you
> > about Tim's suggestion and the patch?
> >
> > The following step would be to do something about class library
> > natives which are rebuilt each time.
> >
> > [1] https://issues.apache.org/jira/browse/HARMONY-5521
> > [2] https://issues.apache.org/jira/secure/attachment/12378724/incremental_build_1.patch
> >
> > On Thu, Mar 27, 2008 at 5:29 PM, Tim Ellison (JIRA) <ji...@apache.org> wrote:
> >>
> >> [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582662#action_12582662 ]
> >>
> >> Tim Ellison commented on HARMONY-5521:
> >> --------------------------------------
> >>
> >> Why not make the incremental build the default? This is more likely the one people will be using daily.
> >>
> >>
> >> > [build] fix incremental federated build
> >> > ---------------------------------------
> >> >
> >> > Key: HARMONY-5521
> >> > URL: https://issues.apache.org/jira/browse/HARMONY-5521
> >> > Project: Harmony
> >> > Issue Type: Improvement
> >> > Components: build - test - ci
> >> > Reporter: Alexei Fedotov
> >> > Assignee: Pavel Pervov
> >> > Attachments: incremental_build.patch
> >> >
> >> >
> >> > This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> -
> >> You can reply to this email to add a comment to the issue online.
> >>
> >>
> >
> >
> >
>
--
With best regards,
Alexei
Re: Changing default federated build target Was: [jira] Commented:
(HARMONY-5521) [build] fix incremental federated build
Posted by Tim Ellison <t....@gmail.com>.
FWIW the names used in the classlib level build script are:
build - default target, does an incremental build
clean - as you would expect
rebuild - clean followed by build
...
Maybe it would be good to be consistent with the names here.
Regards,
Tim
Alexei Fedotov wrote:
> Tim wrote in HARMONY-5521:
>> Why not make the incremental build the default? This is more likely the one people will be using daily.
>
> We should ask people who are in charge of snapshot creation since they
> probably use a default target for their script now. It might be good
> to rename the "default" target into "all" or something because it
> would not be conventional to call it "default" any longer. This is
> done via incremental_build_1.patch [2]. Stepan, Alexey, what do you
> about Tim's suggestion and the patch?
>
> The following step would be to do something about class library
> natives which are rebuilt each time.
>
> [1] https://issues.apache.org/jira/browse/HARMONY-5521
> [2] https://issues.apache.org/jira/secure/attachment/12378724/incremental_build_1.patch
>
> On Thu, Mar 27, 2008 at 5:29 PM, Tim Ellison (JIRA) <ji...@apache.org> wrote:
>>
>> [ https://issues.apache.org/jira/browse/HARMONY-5521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582662#action_12582662 ]
>>
>> Tim Ellison commented on HARMONY-5521:
>> --------------------------------------
>>
>> Why not make the incremental build the default? This is more likely the one people will be using daily.
>>
>>
>> > [build] fix incremental federated build
>> > ---------------------------------------
>> >
>> > Key: HARMONY-5521
>> > URL: https://issues.apache.org/jira/browse/HARMONY-5521
>> > Project: Harmony
>> > Issue Type: Improvement
>> > Components: build - test - ci
>> > Reporter: Alexei Fedotov
>> > Assignee: Pavel Pervov
>> > Attachments: incremental_build.patch
>> >
>> >
>> > This is a patch which enables incremental Harmony build via conventional federated build option "build". Testing changes.
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>>
>
>
>
Re: Changing default federated build target Was: [jira] Commented: (HARMONY-5521) [build] fix incremental federated build
Posted by Stepan Mishura <st...@gmail.com>.
On 3/28/08, Alexey Varlamov <al...@gmail.com> wrote:
> Alexei,
>
> Thanks for pursuing this issue. I agree, a set of "build", "clean",
> "rebuild", "all" will constitute convenient and customary interface,
> and the "build" should be default.
> We would only need to ask Stepan update "make-snapshot" adaptors and
> CCs thereafter.
I'd like to ask everybody - please don't commit such changes on Friday evening.
I need time to update the infra/CCs to perform weekend's testing.
-Stepan.
>
> --
> Alexey
>
Re: Changing default federated build target Was: [jira] Commented: (HARMONY-5521) [build] fix incremental federated build
Posted by Alexey Varlamov <al...@gmail.com>.
Alexei,
Thanks for pursuing this issue. I agree, a set of "build", "clean",
"rebuild", "all" will constitute convenient and customary interface,
and the "build" should be default.
We would only need to ask Stepan update "make-snapshot" adaptors and
CCs thereafter.
--
Alexey
Re: Changing default federated build target Was: [jira] Commented: (HARMONY-5521) [build] fix incremental federated build
Posted by Stepan Mishura <st...@gmail.com>.
On 3/27/08, Alexei Fedotov <al...@gmail.com> wrote:
> Tim wrote in HARMONY-5521:
> > Why not make the incremental build the default? This is more likely the one people will be using daily.
>
> We should ask people who are in charge of snapshot creation since they
> probably use a default target for their script now. It might be good
> to rename the "default" target into "all" or something because it
> would not be conventional to call it "default" any longer. This is
> done via incremental_build_1.patch [2]. Stepan, Alexey, what do you
> about Tim's suggestion and the patch?
>
I'm OK with the suggested change: make the incremental build the
default + add rebuild target.
-Stepan.
> The following step would be to do something about class library
> natives which are rebuilt each time.
>
> [1] https://issues.apache.org/jira/browse/HARMONY-5521
> [2] https://issues.apache.org/jira/secure/attachment/12378724/incremental_build_1.patch
>
<SNIP>