You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/07/31 05:18:00 UTC
[GitHub] [jackrabbit-oak] nit0906 opened a new pull request, #645: OAK-9870 | Escaped characters from client get unescaped in ES implementation
nit0906 opened a new pull request, #645:
URL: https://github.com/apache/jackrabbit-oak/pull/645
As part of https://github.com/apache/jackrabbit-oak/commit/695d5ab33ec23ad5cae9fd47dc5f207d6dc0cd6c, we handled the case of double negation in case of ES implementation by not using raw text from FullTextContains and instead using text from FullTextTerm to build the final ES query.
This fixed the double negation, but broke another case where the client might be escaping special characters such as '{' . But FullTextTerm#getText() does not have the escapes as opposed to FullTextContains#getRawText() that was used previously.
We are not handling these escapes in backend so as to not change the current behaviour of lucene which basically expects the client to escape some special characters such as '{' and if these are not escaped by client - then the query fails silently (logging failure and returning 0 results) - The newly added tests in this PR try and demonstrate the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jackrabbit-oak] nit0906 merged pull request #645: OAK-9870 | Escaped characters from client get unescaped in ES implementation
Posted by GitBox <gi...@apache.org>.
nit0906 merged PR #645:
URL: https://github.com/apache/jackrabbit-oak/pull/645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org