You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "MaksYermak (via GitHub)" <gi...@apache.org> on 2023/09/18 12:09:20 UTC
[GitHub] [airflow] MaksYermak opened a new pull request, #34452: Fix system test for GoogleCalendarToGCSOperator
MaksYermak opened a new pull request, #34452:
URL: https://github.com/apache/airflow/pull/34452
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
In this PR I have updated the system test for GoogleCalendarToGCSOperator.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #34452: Fix system test for GoogleCalendarToGCSOperator
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #34452:
URL: https://github.com/apache/airflow/pull/34452#discussion_r1328756870
##########
tests/system/providers/google/cloud/gcs/example_calendar_to_gcs.py:
##########
@@ -44,6 +52,26 @@
task_id="create_bucket", bucket_name=BUCKET_NAME, project_id=PROJECT_ID
)
+ @task
+ def create_temp_gcp_connection():
+ conn = Connection(
+ conn_id=CONNECTION_ID,
+ conn_type="google_cloud_platform",
+ )
+ conn_extra = {
+ "scope": "https://www.googleapis.com/auth/calendar",
+ "project": PROJECT_ID,
+ "keyfile_dict": "", # Override to match your needs
+ }
+ conn_extra_json = json.dumps(conn_extra)
+ conn.set_extra(conn_extra_json)
+
+ session: Session = Session()
+ session.add(conn)
+ session.commit()
Review Comment:
Not related to this PR, we have same pattern in the different system tests.
Just my thought, should we replace connection creation in the future by generic one in System Tests and mark that it only for test purpose (_All the stunts performed by professionals, do not try it yourself at home_ 🤣 ).
Because we use system tests also as example so I wondering that user might decide that this it recommended/supported way to create Connection dynamically
cc @hussein-awala @uranusjr @potiuk @eladkal @o-nikolas
##########
tests/system/providers/google/cloud/gcs/example_calendar_to_gcs.py:
##########
@@ -44,6 +52,26 @@
task_id="create_bucket", bucket_name=BUCKET_NAME, project_id=PROJECT_ID
)
+ @task
+ def create_temp_gcp_connection():
+ conn = Connection(
+ conn_id=CONNECTION_ID,
+ conn_type="google_cloud_platform",
+ )
+ conn_extra = {
+ "scope": "https://www.googleapis.com/auth/calendar",
+ "project": PROJECT_ID,
+ "keyfile_dict": "", # Override to match your needs
+ }
+ conn_extra_json = json.dumps(conn_extra)
+ conn.set_extra(conn_extra_json)
+
+ session: Session = Session()
+ session.add(conn)
+ session.commit()
Review Comment:
Not related to this PR, we have same pattern in the different system tests.
Just my thought, should we replace connection creation in the future by generic one in System Tests and mark that it only for test purpose (_All the stunts performed by professionals, do not try it yourself at home_ 🤣 ).
Because we use system tests also as example so I wondering that user might decide that this it recommended/supported way to create Connection dynamically
cc @hussein-awala @uranusjr @potiuk @eladkal @o-nikolas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix system test for GoogleCalendarToGCSOperator [airflow]
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on PR #34452:
URL: https://github.com/apache/airflow/pull/34452#issuecomment-1790495962
Hi @potiuk @eladkal !
@Taragolis , thank you, I think this could be moved to our Slack chat to discuss it inside Community, because it is not related to the current PR
Could you please take a look at this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix system test for GoogleCalendarToGCSOperator [airflow]
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis merged PR #34452:
URL: https://github.com/apache/airflow/pull/34452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org