[GitHub] flink pull request #4531: [FLINK-7434][doc] scafolding with "sbt new"

[sv3nd <gi...@git.apache.org>]

GitHub user sv3nd opened a pull request:

    https://github.com/apache/flink/pull/4531

    [FLINK-7434][doc] scafolding with "sbt new"

    
    ## What is the purpose of the change
    
    Current [documentation for scala project scafolding from template](https://ci.apache.org/projects/flink/flink-docs-release-1.3/quickstart/scala_api_quickstart.html#create-project) mentions that giter8 needs to be installed. 
    
    The purpose of this documentation update is to clarify that such installation is not required, making it easier to newcomers (and others) to start coding a flink project. 
    
    ## Brief change log
    
    Documents  how to use `sbt new` instead of `giter8`.  `sbt` is very likely to already be installed since this is a commonly used developer tool, especially given that the target user here is a scala developer.  
    
    Also, removes the reference to cloning the git project, since that method is more cumbersome for 2 reasons:
    - requires the user to remove the `.git` folder after the `git clone`
    - is not template based => folders and versions are hard-coded
    
    Also, removing this method imply that one less template needs to be maintained. 
    
    ## Verifying this change
    
      -*Manually verified the change by running `./build_docs.sh -p` from inside the docker container available in `docs/docker`
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
      - The serializers: ( no )
      - The runtime per-record code paths (performance sensitive): (no )
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no )
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? ( docs )
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sv3nd/flink doc_scala_sbt_new

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4531.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4531
    
----
commit caadb32807abc9bea97a34f8e7fe87431697d717
Author: Svend Vanderveken <sv...@gmail.com>
Date:   2017-08-12T09:11:36Z

    [FLINK-7434][doc] scafolding with "sbt new"
    
    Since the generated project is an sbt project, it is
    much more straightfoward for the user to create it with
    the new "sbt new" command than by using giter8 (which
    requires to install giter8 just for that purpose).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #4531: [FLINK-7434][doc] scafolding with "sbt new"

[tillrohrmann <gi...@git.apache.org>]

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/4531
  
    Changes look good to me. Thanks a lot for your contribution @sv3nd :-) Merging this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #4531: [FLINK-7434][doc] scafolding with "sbt new"

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4531


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---