You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ygerzhedovich (via GitHub)" <gi...@apache.org> on 2023/05/10 15:30:42 UTC
[GitHub] [ignite-3] ygerzhedovich opened a new pull request, #2056: IGNITE-15507: correct type mapping for JDBC metadata.
ygerzhedovich opened a new pull request, #2056:
URL: https://github.com/apache/ignite-3/pull/2056
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2056: IGNITE-15507: correct type mapping for JDBC metadata.
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2056:
URL: https://github.com/apache/ignite-3/pull/2056#discussion_r1211722780
##########
modules/api/src/main/java/org/apache/ignite/sql/ColumnType.java:
##########
@@ -164,4 +164,23 @@ public static Class<?> columnTypeToClass(ColumnType type) {
throw new IllegalArgumentException("Unsupported type " + type);
}
}
+
+ /**
+ * Column type to Java class for JDBC.
+ */
+ public static Class<?> columnTypeToJdbcClass(ColumnType type) {
Review Comment:
As I see, methods 'columnTypeToJdbcClass' and 'columnTypeToClass' are used in
* clients, client-handler modules to return correct java class for particular client
* sql-engine module to return correct java class in case of embedded node
The common modules for all of them is ignite-client-common module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #2056: IGNITE-15507: correct type mapping for JDBC metadata.
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #2056:
URL: https://github.com/apache/ignite-3/pull/2056#discussion_r1222950393
##########
modules/api/src/main/java/org/apache/ignite/sql/ColumnType.java:
##########
@@ -164,4 +164,23 @@ public static Class<?> columnTypeToClass(ColumnType type) {
throw new IllegalArgumentException("Unsupported type " + type);
}
}
+
+ /**
+ * Column type to Java class for JDBC.
+ */
+ public static Class<?> columnTypeToJdbcClass(ColumnType type) {
Review Comment:
@AMashenkov thanks for pointing me. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov merged pull request #2056: IGNITE-15507: correct type mapping for JDBC metadata.
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov merged PR #2056:
URL: https://github.com/apache/ignite-3/pull/2056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2056: IGNITE-15507: correct type mapping for JDBC metadata.
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2056:
URL: https://github.com/apache/ignite-3/pull/2056#discussion_r1211722780
##########
modules/api/src/main/java/org/apache/ignite/sql/ColumnType.java:
##########
@@ -164,4 +164,23 @@ public static Class<?> columnTypeToClass(ColumnType type) {
throw new IllegalArgumentException("Unsupported type " + type);
}
}
+
+ /**
+ * Column type to Java class for JDBC.
+ */
+ public static Class<?> columnTypeToJdbcClass(ColumnType type) {
Review Comment:
As I see, methods 'columnTypeToJdbcClass' and 'columnTypeToClass' are used in
* clients, client-handler modules - to return correct java class for particular client
* sql-engine module - to return correct java class in case of embedded node
The common module for all of them is ignite-client-common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #2056: IGNITE-15507: correct type mapping for JDBC metadata.
Posted by "ygerzhedovich (via GitHub)" <gi...@apache.org>.
ygerzhedovich commented on code in PR #2056:
URL: https://github.com/apache/ignite-3/pull/2056#discussion_r1198856799
##########
modules/api/src/main/java/org/apache/ignite/sql/ColumnType.java:
##########
@@ -164,4 +164,23 @@ public static Class<?> columnTypeToClass(ColumnType type) {
throw new IllegalArgumentException("Unsupported type " + type);
}
}
+
+ /**
+ * Column type to Java class for JDBC.
+ */
+ public static Class<?> columnTypeToJdbcClass(ColumnType type) {
Review Comment:
I agree that API module is bad choice for the utility methods, however core module does not depends API and I'm not sure that should be so.I can't find good module to move the methods.
My proposal think about right place and move it in separate ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] AMashenkov commented on a diff in pull request #2056: IGNITE-15507: correct type mapping for JDBC metadata.
Posted by "AMashenkov (via GitHub)" <gi...@apache.org>.
AMashenkov commented on code in PR #2056:
URL: https://github.com/apache/ignite-3/pull/2056#discussion_r1197639813
##########
modules/api/src/main/java/org/apache/ignite/sql/ColumnType.java:
##########
@@ -164,4 +164,23 @@ public static Class<?> columnTypeToClass(ColumnType type) {
throw new IllegalArgumentException("Unsupported type " + type);
}
}
+
+ /**
+ * Column type to Java class for JDBC.
+ */
+ public static Class<?> columnTypeToJdbcClass(ColumnType type) {
Review Comment:
Can we move this method along with columnTypeToClass() from public api to the ignite-core module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org