You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/30 10:07:45 UTC
[GitHub] [pulsar] sijie opened a new pull request #9094: [Authentication] Support chained authentication with same auth method name
sijie opened a new pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094
*Motivation*
Chained authentication is a very useful mechanism for migrating a cluster from
one authentication provider to the other authentication provider. However,
Pulsar doesn't support configuring multiple authentication providers with same
auth method name.
For example, a Pulsar cluster was using standard JWT authentication initially.
The users want to upgrade the Pulsar cluster to use an OAuth2 authentication
mechanism. But both JWT and OAuth2 share the same authentication method name.
This change improves the authentication logic to support chained authentication
with same auth method name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094#issuecomment-752831662
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094#issuecomment-753256230
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094#issuecomment-754182386
@codelipenghui I have just pushed a change to fix the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094#issuecomment-753566522
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094#issuecomment-754264665
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094#issuecomment-752637057
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094#issuecomment-753717888
@sijie There is a failed test, please take a look
```
Error: Tests run: 3, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 26.913 s <<< FAILURE! - in org.apache.pulsar.broker.authentication.SaslAuthenticateTest
Error: testSaslServerAndClientAuth(org.apache.pulsar.broker.authentication.SaslAuthenticateTest) Time elapsed: 0.011 s <<< FAILURE!
java.lang.ClassCastException: org.apache.pulsar.broker.authentication.AuthenticationProviderList cannot be cast to org.apache.pulsar.broker.authentication.AuthenticationProviderSasl
at org.apache.pulsar.broker.authentication.SaslAuthenticateTest.testSaslServerAndClientAuth(SaslAuthenticateTest.java:256)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094#issuecomment-753243732
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094#issuecomment-753581910
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094#issuecomment-752697623
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #9094: [Authentication] Support chained authentication with same auth method name
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #9094:
URL: https://github.com/apache/pulsar/pull/9094#issuecomment-752495077
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org