You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Mengwei Ding <me...@gmail.com> on 2013/07/02 02:27:07 UTC
Review Request 12218: SQOOP-997 provide ability to disable the automatic
upgrade for connectors and framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12218/
-----------------------------------------------------------
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Bugs: SQOOP-997
https://issues.apache.org/jira/browse/SQOOP-997
Repository: sqoop-sqoop2
Description
-------
commit f6b3bb1a61c2e9cd3736c5a05882ace390705536
Author: Mengwei Ding <me...@cloudera.com>
Date: Mon Jul 1 17:19:27 2013 -0700
SQOOP-997 provide ability to disable the automatic upgrade for connectors and framework.
:100644 100644 0540f6b... 12767d3... M core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
:100644 100644 838aaaf... f225fcb... M core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java
:100644 100644 a81306b... 008817d... M core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
:100644 100644 aa1aa8d... 7a6501f... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
:100644 100644 306bd90... e77eac8... M core/src/main/java/org/apache/sqoop/repository/Repository.java
:100755 100755 07b148e... 76596b4... M dist/src/main/server/conf/sqoop.properties
Diffs
-----
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0540f6b
core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java 838aaaf
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java a81306b
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java aa1aa8d
core/src/main/java/org/apache/sqoop/repository/Repository.java 306bd90
dist/src/main/server/conf/sqoop.properties 07b148e
Diff: https://reviews.apache.org/r/12218/diff/
Testing
-------
Thanks,
Mengwei Ding
Re: Review Request 12218: SQOOP-997 provide ability to disable the automatic
upgrade for connectors and framework.
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12218/#review22687
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On July 2, 2013, 6:41 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12218/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 6:41 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-997
> https://issues.apache.org/jira/browse/SQOOP-997
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit bfd2a7d35c83cdbf3e21c64ea77fcec41b258b9a
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Mon Jul 1 17:19:27 2013 -0700
>
> SQOOP-997 provide ability to disable the automatic upgrade for connectors and framework.
>
> :100644 100644 0540f6b... fa91d02... M core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
> :100644 100644 838aaaf... f225fcb... M core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java
> :100644 100644 a81306b... ad6cd0f... M core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
> :100644 100644 aa1aa8d... 2d9bf4e... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
> :100644 100644 306bd90... 46cb7e6... M core/src/main/java/org/apache/sqoop/repository/Repository.java
> :100644 100644 ab5e5a1... c616889... M core/src/main/java/org/apache/sqoop/repository/RepositoryError.java
> :100755 100755 07b148e... 76596b4... M dist/src/main/server/conf/sqoop.properties
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0540f6b
> core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java 838aaaf
> core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java a81306b
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java aa1aa8d
> core/src/main/java/org/apache/sqoop/repository/Repository.java 306bd90
> core/src/main/java/org/apache/sqoop/repository/RepositoryError.java ab5e5a1
> dist/src/main/server/conf/sqoop.properties 07b148e
>
> Diff: https://reviews.apache.org/r/12218/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 12218: SQOOP-997 provide ability to disable the automatic
upgrade for connectors and framework.
Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12218/
-----------------------------------------------------------
(Updated July 2, 2013, 6:41 p.m.)
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Bugs: SQOOP-997
https://issues.apache.org/jira/browse/SQOOP-997
Repository: sqoop-sqoop2
Description (updated)
-------
commit bfd2a7d35c83cdbf3e21c64ea77fcec41b258b9a
Author: Mengwei Ding <me...@cloudera.com>
Date: Mon Jul 1 17:19:27 2013 -0700
SQOOP-997 provide ability to disable the automatic upgrade for connectors and framework.
:100644 100644 0540f6b... fa91d02... M core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
:100644 100644 838aaaf... f225fcb... M core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java
:100644 100644 a81306b... ad6cd0f... M core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
:100644 100644 aa1aa8d... 2d9bf4e... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
:100644 100644 306bd90... 46cb7e6... M core/src/main/java/org/apache/sqoop/repository/Repository.java
:100644 100644 ab5e5a1... c616889... M core/src/main/java/org/apache/sqoop/repository/RepositoryError.java
:100755 100755 07b148e... 76596b4... M dist/src/main/server/conf/sqoop.properties
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0540f6b
core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java 838aaaf
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java a81306b
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java aa1aa8d
core/src/main/java/org/apache/sqoop/repository/Repository.java 306bd90
core/src/main/java/org/apache/sqoop/repository/RepositoryError.java ab5e5a1
dist/src/main/server/conf/sqoop.properties 07b148e
Diff: https://reviews.apache.org/r/12218/diff/
Testing
-------
Thanks,
Mengwei Ding
Re: Review Request 12218: SQOOP-997 provide ability to disable the automatic
upgrade for connectors and framework.
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12218/#review22638
-----------------------------------------------------------
+1 Looks good to me.
- Abraham Elmahrek
On July 2, 2013, 12:27 a.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12218/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 12:27 a.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-997
> https://issues.apache.org/jira/browse/SQOOP-997
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit f6b3bb1a61c2e9cd3736c5a05882ace390705536
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Mon Jul 1 17:19:27 2013 -0700
>
> SQOOP-997 provide ability to disable the automatic upgrade for connectors and framework.
>
> :100644 100644 0540f6b... 12767d3... M core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
> :100644 100644 838aaaf... f225fcb... M core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java
> :100644 100644 a81306b... 008817d... M core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
> :100644 100644 aa1aa8d... 7a6501f... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
> :100644 100644 306bd90... e77eac8... M core/src/main/java/org/apache/sqoop/repository/Repository.java
> :100755 100755 07b148e... 76596b4... M dist/src/main/server/conf/sqoop.properties
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0540f6b
> core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java 838aaaf
> core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java a81306b
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java aa1aa8d
> core/src/main/java/org/apache/sqoop/repository/Repository.java 306bd90
> dist/src/main/server/conf/sqoop.properties 07b148e
>
> Diff: https://reviews.apache.org/r/12218/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 12218: SQOOP-997 provide ability to disable the automatic
upgrade for connectors and framework.
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12218/#review22669
-----------------------------------------------------------
Hi Mengwei,
thank you very much for working on this patch, greatly appreciated!
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
<https://reviews.apache.org/r/12218/#comment46355>
Nit: We are using camel case for variable names.
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
<https://reviews.apache.org/r/12218/#comment46354>
Nit: We are using camel case for variable names.
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
<https://reviews.apache.org/r/12218/#comment46352>
Nit: We are using camel case for variable names.
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
<https://reviews.apache.org/r/12218/#comment46350>
Would it be possible to improve user friendliness of this check? What about throwing an exception like "upgrade required by not allowed" in case that we need to upgrade the connector metadata, but autoUgprade is turned off?
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
<https://reviews.apache.org/r/12218/#comment46353>
Nit: We are using camel case for variable names.
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
<https://reviews.apache.org/r/12218/#comment46351>
Would it be possible to improve user friendliness of this check? What about throwing an exception like "upgrade required by not allowed" in case that we need to upgrade the connector metadata, but autoUgprade is turned off?
Jarcec
- Jarek Cecho
On July 2, 2013, 12:27 a.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12218/
> -----------------------------------------------------------
>
> (Updated July 2, 2013, 12:27 a.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-997
> https://issues.apache.org/jira/browse/SQOOP-997
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit f6b3bb1a61c2e9cd3736c5a05882ace390705536
> Author: Mengwei Ding <me...@cloudera.com>
> Date: Mon Jul 1 17:19:27 2013 -0700
>
> SQOOP-997 provide ability to disable the automatic upgrade for connectors and framework.
>
> :100644 100644 0540f6b... 12767d3... M core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
> :100644 100644 838aaaf... f225fcb... M core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java
> :100644 100644 a81306b... 008817d... M core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
> :100644 100644 aa1aa8d... 7a6501f... M core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
> :100644 100644 306bd90... e77eac8... M core/src/main/java/org/apache/sqoop/repository/Repository.java
> :100755 100755 07b148e... 76596b4... M dist/src/main/server/conf/sqoop.properties
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java 0540f6b
> core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java 838aaaf
> core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java a81306b
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java aa1aa8d
> core/src/main/java/org/apache/sqoop/repository/Repository.java 306bd90
> dist/src/main/server/conf/sqoop.properties 07b148e
>
> Diff: https://reviews.apache.org/r/12218/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>