You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Xiaodong DENG (JIRA)" <ji...@apache.org> on 2018/09/15 14:19:00 UTC
[jira] [Updated] (AIRFLOW-3067) (www_rbac) Flask flash messages are
not categoried properly (result in 'incomplete' UI display)
[ https://issues.apache.org/jira/browse/AIRFLOW-3067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xiaodong DENG updated AIRFLOW-3067:
-----------------------------------
Attachment: 2.png
1.png
Summary: (www_rbac) Flask flash messages are not categoried properly (result in 'incomplete' UI display) (was: (www_rbac) Flask flash messages not categoried (result in 'incomplete' UI display))
> (www_rbac) Flask flash messages are not categoried properly (result in 'incomplete' UI display)
> -----------------------------------------------------------------------------------------------
>
> Key: AIRFLOW-3067
> URL: https://issues.apache.org/jira/browse/AIRFLOW-3067
> Project: Apache Airflow
> Issue Type: Improvement
> Components: webapp
> Affects Versions: 1.10.0
> Reporter: Xiaodong DENG
> Assignee: Xiaodong DENG
> Priority: Critical
> Attachments: 1.png, 2.png
>
>
> The Flask flash messages are not categorized properly (ref: [http://flask.pocoo.org/docs/1.0/patterns/flashing/#flashing-with-categories).] This makes the the flash messages in the _*www_rbac*_ UI come with no background color (please check the screenshots attached. We don't see this issue in _*www*_ UI as all flash messages without categories are classed into 'info').
> Solution:
> * Add proper category when we invoke *flash()*.
> * We can't use category 'error'. Flask AppBuild would assign class `alert-[category]` to that message when dispalying it (ref: https://github.com/dpgaspar/Flask-AppBuilder/blob/master/flask_appbuilder/templates/appbuilder/flash.html ). In bootstrap-theme.css, we don't have `alert-error` (we have `alert-danger` instead).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)