[GitHub] [incubator-druid] leerho commented on issue #8647: use the latest release of datasketches

[GitBox <gi...@apache.org>]

leerho commented on issue #8647: use the latest release of datasketches
URL: https://github.com/apache/incubator-druid/pull/8647#issuecomment-566657965
 
 
   @xvrl 
   That would be great!  
   
   I did some poking around and found that an updated Unsafe still exists in JDK11, although for how long I don't know.    I did some timing measurements and discovered that unsafe calls are noticeably slower in JDK11 than JDK8.   Possibly some redirect has been inserted.  Do you have any explanation?
   
   It is my understanding, that the intention is that var-handles and method handles are to replace unsafe calls.   The way we use Unsafe is mostly to read-write primitives and arrays into blobs of bytes similar to what one can do with the C union / struct.   If we can replicate that with these var-handles, then we will probably be OK. 
   
   We will also likely need to setup Multi-Release Jars (MRJARS) to accommodate both JDK8 and JDK11 code sets.  I have no experience in doing this.
   
   Thanks again for your offer of help!!
   
   Lee.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org