[jira] [Commented] (BCEL-262) InvokeInstruction.getClassName(ConstantPoolGen) should throw an exception when it detects an array

["Gary Gregory (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BCEL-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364717#comment-15364717 ] 

Gary Gregory commented on BCEL-262:
-----------------------------------

But still no unit test? How can we make sure we will not have a regression? Or that this actually fixes something?

> InvokeInstruction.getClassName(ConstantPoolGen) should throw an exception when it detects an array
> --------------------------------------------------------------------------------------------------
>
>                 Key: BCEL-262
>                 URL: https://issues.apache.org/jira/browse/BCEL-262
>             Project: Commons BCEL
>          Issue Type: Improvement
>            Reporter: Sebb
>            Assignee: Benedikt Ritter
>             Fix For: 6.0
>
>         Attachments: InvokeInstruction.diff
>
>
> The method FieldOrMethod.getClassName(ConstantPoolGen cpg) is deprecated because it can return java.lang.Object for arrays.
> Now the method is defined in the superclass for FieldInstructions and InvokeInstructions.
> In the case of InvokeInstructions, can these ever reference an Array?
> If not, then the method could be overridden in the InvokeInstruction class.
> This new method would throw an unchecked Exception if detects an Array.
> This would change the behaviour of the method for subclasses of InvokeInstruction, but they would not need to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)