You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/10/08 21:29:38 UTC

Re: Review Request 29550: Libprocess: Added "tests" target for make.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29550/
-----------------------------------------------------------

(Updated Oct. 8, 2015, 3:29 p.m.)


Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.


Bugs: MESOS-2273
    https://issues.apache.org/jira/browse/MESOS-2273


Repository: mesos


Description
-------

'make check' allows one to build and run the test suite. However,
'make tests' allows one to build the test suite without running it.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500 
  3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 

Diff: https://reviews.apache.org/r/29550/diff/


Testing
-------

Ran make tests.

For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.


Thanks,

Kapil Arya

Re: Review Request 29550: Libprocess: Added "tests" target for make.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29550/#review102626
-----------------------------------------------------------


I ran `make tests` from `3rdparty/libprocess` and ran in to:
`make: *** No rule to make target '3rdparty/libgmock.la', needed by 'libprocess-tests'.  Stop.`

- Joris Van Remoortere


On Oct. 8, 2015, 7:29 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29550/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 7:29 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.
> 
> 
> Bugs: MESOS-2273
>     https://issues.apache.org/jira/browse/MESOS-2273
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> 'make check' allows one to build and run the test suite. However,
> 'make tests' allows one to build the test suite without running it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500 
>   3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 
> 
> Diff: https://reviews.apache.org/r/29550/diff/
> 
> 
> Testing
> -------
> 
> Ran make tests.
> 
> For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 29550: Libprocess: Added "tests" target for make.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29550/#review103026
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On Oct. 14, 2015, 6:31 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29550/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 6:31 p.m.)
> 
> 
> Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.
> 
> 
> Bugs: MESOS-2273
>     https://issues.apache.org/jira/browse/MESOS-2273
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> 'make check' allows one to build and run the test suite. However,
> 'make tests' allows one to build the test suite without running it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500 
>   3rdparty/libprocess/Makefile.am eb7393904988afc0bc5e9f7dadd545e0d6c04e5f 
> 
> Diff: https://reviews.apache.org/r/29550/diff/
> 
> 
> Testing
> -------
> 
> Ran make tests.
> 
> For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 29550: Libprocess: Added "tests" target for make.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29550/
-----------------------------------------------------------

(Updated Oct. 14, 2015, 2:31 p.m.)


Review request for mesos, Cody Maloney, Joris Van Remoortere, Timothy Chen, and Timothy St. Clair.


Changes
-------

Fixed dependency order for libprocess-tests.


Bugs: MESOS-2273
    https://issues.apache.org/jira/browse/MESOS-2273


Repository: mesos


Description
-------

'make check' allows one to build and run the test suite. However,
'make tests' allows one to build the test suite without running it.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/Makefile.am e64e3d9e958fab3c7c25fad17dcc2b279d255500 
  3rdparty/libprocess/Makefile.am eb7393904988afc0bc5e9f7dadd545e0d6c04e5f 

Diff: https://reviews.apache.org/r/29550/diff/


Testing
-------

Ran make tests.

For added test, ran "make clean; make; make tests" followed by "make check" and verified that no additional target are build in the "make check" step.


Thanks,

Kapil Arya