You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by itaifrenkel <gi...@git.apache.org> on 2015/08/14 13:08:30 UTC
[GitHub] storm pull request: ShellBolt should treat ack and fail as heartbe...
GitHub user itaifrenkel opened a pull request:
https://github.com/apache/storm/pull/685
ShellBolt should treat ack and fail as heartbeat
Python queues up requests, and it can handle many requests before reaching the __heartbeat signal, so the shellbolt must treat ack/fail as heartbeat too.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/forter/storm improved-shellbolt-heartbeat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/685.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #685
----
commit 421aa27b87a707923cf374837c4556dd4a992e54
Author: Itai Frenkel <it...@forter.com>
Date: 2015-08-14T10:41:13Z
Treat ack and fail as heartbeat
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #685: ShellBolt should treat ack and fail as heartbeat
Posted by itaifrenkel <gi...@git.apache.org>.
Github user itaifrenkel closed the pull request at:
https://github.com/apache/storm/pull/685
---
[GitHub] storm pull request: ShellBolt should treat ack and fail as heartbe...
Posted by itaifrenkel <gi...@git.apache.org>.
Github user itaifrenkel commented on the pull request:
https://github.com/apache/storm/pull/685#issuecomment-131539757
@HeartSaVioR I also recommend this fix https://github.com/forter/storm/commit/70f5689b15ab5c6092ed2310fdde4820a4f7bc0d
Otherwise the bolt can fail when preparing in a busy build server (race condition between reader and heartbeat threads)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: ShellBolt should treat ack and fail as heartbe...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/685#issuecomment-131084050
@itaifrenkel
Thanks for the work, but it was already addressed.
https://issues.apache.org/jira/browse/STORM-742
Could you review https://github.com/apache/storm/pull/497 and comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: ShellBolt should treat ack and fail as heartbe...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/685#issuecomment-167625790
@itaifrenkel,
If this is still an issue, would you create a Jira for it and fix the conflicts with the master branch?
Otherwise, if the problem is resolved, would you close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---