You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Shinichi Yamashita <ya...@oss.nttdata.co.jp> on 2015/12/26 14:08:04 UTC

Review Request 41723: HIVE-12372: Improve to support the multibyte character at lpad and rpad

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41723/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-12372
    https://issues.apache.org/jira/browse/HIVE-12372


Repository: hive-git


Description
-------

HIVE-12372: Improve to support the multibyte character at lpad and rpad


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java 33839f7 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLpad.java f15a869 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRpad.java b512332 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLpad.java 6344417 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRpad.java 71ffcb9 

Diff: https://reviews.apache.org/r/41723/diff/


Testing
-------

TestGenericUDFLpad#testLpad
TestGenericUDFRpad#testRpad


Thanks,

Shinichi Yamashita


Re: Review Request 41723: HIVE-12372: Improve to support the multibyte character at lpad and rpad

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41723/#review112104
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java (lines 73 - 77)
<https://reviews.apache.org/r/41723/#comment172416>

    This if-else branch will be evaluated for each evaluate() which means every row and if will be false only once (first time). For performance reasons, its better to just create string builder object at time of declaration and then do setLength(0) here.



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLpad.java (lines 47 - 48)
<https://reviews.apache.org/r/41723/#comment172421>

    This loop can be optimized using one of builder.append() overload methods.



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLpad.java (lines 53 - 54)
<https://reviews.apache.org/r/41723/#comment172419>

    Instead following more performant version could be used:
    builder.append(str, 0, str.length());
    builder.setLength(len);



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRpad.java (lines 45 - 46)
<https://reviews.apache.org/r/41723/#comment172420>

    can be optimized using:
    builder.append(str, 0, str.length());
    builder.setLength(len);



ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRpad.java (lines 51 - 54)
<https://reviews.apache.org/r/41723/#comment172422>

    This loop can be optimized using one of stringbuilder::append() overload methods.


- Ashutosh Chauhan


On Dec. 26, 2015, 1:08 p.m., Shinichi Yamashita wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41723/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2015, 1:08 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-12372
>     https://issues.apache.org/jira/browse/HIVE-12372
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-12372: Improve to support the multibyte character at lpad and rpad
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java 33839f7 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLpad.java f15a869 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRpad.java b512332 
>   ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLpad.java 6344417 
>   ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRpad.java 71ffcb9 
> 
> Diff: https://reviews.apache.org/r/41723/diff/
> 
> 
> Testing
> -------
> 
> TestGenericUDFLpad#testLpad
> TestGenericUDFRpad#testRpad
> 
> 
> Thanks,
> 
> Shinichi Yamashita
> 
>


Re: Review Request 41723: HIVE-12372: Improve to support the multibyte character at lpad and rpad

Posted by Shinichi Yamashita <ya...@oss.nttdata.co.jp>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41723/
-----------------------------------------------------------

(Updated Dec. 29, 2015, 9:45 p.m.)


Review request for hive.


Changes
-------

Thank you for your review. I changed the patch file.


Bugs: HIVE-12372
    https://issues.apache.org/jira/browse/HIVE-12372


Repository: hive-git


Description
-------

HIVE-12372: Improve to support the multibyte character at lpad and rpad


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBasePad.java 33839f7 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLpad.java f15a869 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRpad.java b512332 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFLpad.java 6344417 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRpad.java 71ffcb9 

Diff: https://reviews.apache.org/r/41723/diff/


Testing
-------

TestGenericUDFLpad#testLpad
TestGenericUDFRpad#testRpad


Thanks,

Shinichi Yamashita