[GitHub] kristw commented on issue #3947: Add fastdom js dependency

[GitBox <gi...@apache.org>]

kristw commented on issue #3947: Add fastdom js dependency
URL: https://github.com/apache/incubator-superset/pull/3947#issuecomment-408566868
 
 
   `fastdom` has never been imported into the js code, so `window.fastdom` does not exist and `nvd3` in superset did not get the benefits.
   
   From nvd3 https://github.com/novus/nvd3/blob/master/src/dom.js
   ```js
   nv.dom.write = function(callback) {
   	if (window.fastdom !== undefined) {
   		return fastdom.mutate(callback);
   	}
   	return callback();
   };
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org